Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Polynomials v2 in [compat] #301

Closed
mapi1 opened this issue Jan 13, 2022 · 1 comment · Fixed by #302
Closed

Allow Polynomials v2 in [compat] #301

mapi1 opened this issue Jan 13, 2022 · 1 comment · Fixed by #302

Comments

@mapi1
Copy link

mapi1 commented Jan 13, 2022

When adding StateSpaceModels I noticed that some Pkgs (e.g. DSP) get downgraded. The cause is () the Polynomials v1 in the [compat] specification. I ran the tests with the latest version of Polynomials and there seemed to be no change. If this could be confirmed it would be nice to widen compatibility here. Breaking changes are documented here in the case of a more rigorous check.
Thanks again for this great package, it came in handy on several occasions already!
@raphaelsaavedra raphaelsaavedra mentioned this issue Jan 13, 2022
Merged
@raphaelsaavedra
Copy link
Member

Thanks for letting us know – I have opened a PR, if we don't see anything breaking I think this looks safe to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Polynomials v2 LAMPSPUC/StateSpaceModels.jl
2 participants
@raphaelsaavedra @mapi1