Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to disable serial debug (from outside) #4

Open
Westworld opened this issue Jun 10, 2023 · 0 comments
Open

allow to disable serial debug (from outside) #4

Westworld opened this issue Jun 10, 2023 · 0 comments

Comments

@Westworld
Copy link
Contributor

While you allow to disable serial debug, the library set by default:
#define SERIAL_DEBUG

inside the library code. Disabling serial debug require to modify the library source itself, it would be nice if there would be an external flag to disable the automatic enabling...

Even when serial debug is disabled, the library returns twice a 0, because it uses:
Serial.println(mirror_x);
Serial.println(mirror_y);
without checking for SERIAL_DEBUG.

LAutour added a commit that referenced this issue Jun 12, 2023
allow serial debug disable, see #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant