Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Be able to hook/render Sunflare on different cameras #169

Open
jrodrigv opened this issue Jul 31, 2022 · 9 comments
Open

Comments

@jrodrigv
Copy link

Hi. I have a KSP mods which allows to render different cameras at the same time https://youtu.be/Y_JzKbNrnvw?t=306

The problem that I have is that I don't have a way to render all the Scatterer beautiful things in the new cameras. I was wondering if it would be possible for Scatteter to provide an API to inject more cameras apart from the main one. Like an array of NearCameras and ScaledSpace cameras, and camera transforms to apply all the effects etc to those cameras as well?

Thanks in advance

@LGhassen
Copy link
Owner

I will fix it so that it works automatically in the next version.

@jrodrigv
Copy link
Author

Awesome Thanks!

@LGhassen
Copy link
Owner

Just a quick question, how far apart do you expect the different camera views to be? Can one camera be in orbit and the other on the launchpad? Or are they usually very close together like in the video?

@jrodrigv
Copy link
Author

jrodrigv commented Aug 14, 2022

So I'd say that 500 km distance could be a reasonable limit (at > 500 km from the floating origin the shaking is too bad)

@JonnyOThan
Copy link
Contributor

I haven't tried this yet but I think maybe switching the sunflare code to use Camera.current instead of the ScaledSpace camera might work? Just guessing really.

@LGhassen
Copy link
Owner

@JonnyOThan there is that, then the hooks have to be generalized to other cameras, extinction calculation should be moved from skynode to sunflare class and done before every camera renders, then make sure to avoid rendering twice when in opengl (2 local cameras)

@jrodrigv
Copy link
Author

Hi @LGhassen Do you have any updates regarding this topic?

@LGhassen
Copy link
Owner

Not yet, sorry

@jrodrigv
Copy link
Author

no problem! just wondering ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants