Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default ARKODE methods #547

Merged
merged 86 commits into from
Feb 12, 2025
Merged

Update default ARKODE methods #547

merged 86 commits into from
Feb 12, 2025

Conversation

Steven-Roberts
Copy link
Collaborator

@Steven-Roberts Steven-Roberts commented Jul 26, 2024 •
edited
Loading

Replaces #345

In draft status until we settle on the defaults. Then I'll update the docs and output files.

Justification:

  • ARK order >2: Follows the recommendations in the conclusion of https://doi.org/10.1016/j.apnum.2018.10.007
  • ERK order 4: Improved principal error and embedded quality metrics
  • ERK order 5: Improved principal error and embedded quality metrics
  • ERK order 8: Switch to a method designed for local extrapolation mode. Likely better principal error but need to confirm
  • IRK order 2: Improved principal error, L-stability, and stage order 2
  • IRK order >2: Follows the recommendations in the conclusion of https://doi.org/10.1016/j.apnum.2019.07.008

@drreynolds drreynolds mentioned this pull request Sep 5, 2024
Merged
drreynolds added a commit that referenced this pull request Sep 6, 2024
@drreynolds
Removed changesets from PR #547
6f59400
@Steven-Roberts Steven-Roberts marked this pull request as ready for review September 8, 2024 06:31
drreynolds
drreynolds reviewed Sep 10, 2024
View reviewed changes
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Constants.rst Outdated Show resolved Hide resolved
gardner48
gardner48 requested changes Sep 11, 2024
View reviewed changes
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Constants.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
@gardner48 gardner48 force-pushed the feature/rk_defaults branch from aebf685 to 7f2c641 Compare January 31, 2025 22:35
@Steven-Roberts
Copy link
Collaborator Author

I think this is ready to merge unless someone would like to re-review

@gardner48
Copy link
Member

I think this is ready to merge unless someone would like to re-review

It's been a while since I looked over this so I'll take another pass

@drreynolds drreynolds self-requested a review February 7, 2025 22:09
drreynolds
drreynolds previously approved these changes Feb 7, 2025
View reviewed changes
gardner48
gardner48 requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor items, otherwise this looks good

doc/arkode/guide/source/Constants.rst Outdated Show resolved Hide resolved
examples/arkode/C_serial/ark_dissipated_exp_entropy_1_0.out Show resolved Hide resolved
external/sundials-addon-example Outdated Show resolved Hide resolved
test/answers Outdated Show resolved Hide resolved
@Steven-Roberts Steven-Roberts mentioned this pull request Feb 11, 2025
Merged
gardner48 added a commit to sundials-codes/answers that referenced this pull request Feb 12, 2025
@Steven-Roberts @gardner48
Feature/rk defaults (#48)
4a5ce66 
Update outputs for LLNL/sundials#547

---------

Co-authored-by: David J. Gardner <gardner48@llnl.gov>
@gardner48 gardner48 merged commit 35d6d24 into develop Feb 12, 2025
47 checks passed
@gardner48 gardner48 deleted the feature/rk_defaults branch February 12, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardner48 gardner48 gardner48 approved these changes

@drreynolds drreynolds drreynolds left review comments

@balos1 balos1 Awaiting requested review from balos1 balos1 is a code owner

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

Assignees
No one assigned
Labels
pkg-ARKODE
Projects
None yet
Milestone
SUNDIALS Next
Development

Successfully merging this pull request may close these issues.
4 participants
@Steven-Roberts @gardner48 @drreynolds @balos1