Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing ranges for --index-memory-cells, e.g. 1,3-5,9,10-13 #66

Open
reeelix opened this issue May 5, 2024 · 3 comments
Open
Labels
accepted This issue/feature is accepted and will be worked on enhancement New feature or request

Comments

@reeelix
Copy link
Collaborator

reeelix commented May 5, 2024

Allow passing ranges for --index-memory-cells.
For example --index-memory-cells 1,3-5,9,10-13 should be treated like --index-memory-cells 1,3,4,5,9,10,11,12,13. This makes it more convenient to pass a big amount of memory cells.

This change might require some refactoring first, as currently the commandline parameter ``--index-memory-cells` is parsed into a vector of numbers directly by Clap.

@reeelix reeelix added the enhancement New feature or request label May 5, 2024
@reeelix
Copy link
Collaborator Author

reeelix commented May 5, 2024

not urgent

@LMH01 LMH01 added the accepted This issue/feature is accepted and will be worked on label May 5, 2024
@LMH01
Copy link
Owner

LMH01 commented May 5, 2024

Yeah that is another good idea, but implementing it is not so easy, I will have to see how it can be done.

@LMH01
Copy link
Owner

LMH01 commented Dec 19, 2024

I took a look at how this could be implemented but unfortunately it seems not easily possible using clap build in features. The approach that is currently commited on the branch does not work.
I might look for a workaround in the future. You can provide clap with a value parser but that is only used for a single value and not for the whole thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This issue/feature is accepted and will be worked on enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants