Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --disable-instruction-limit from the Playground mode #67

Open
reeelix opened this issue May 5, 2024 · 3 comments
Open

Remove --disable-instruction-limit from the Playground mode #67

reeelix opened this issue May 5, 2024 · 3 comments
Labels
enhancement New feature or request tracking This issue is used to track a specific function or idea but will not be actively worked on

Comments

@reeelix
Copy link
Collaborator

reeelix commented May 5, 2024

In Playground mode, only one instruction is executed at a time. Therefore, applying a limit to the number of executed instructions doesn't make sense there.

Since the option is hidden in the CLI help and will rarely be necessary, this doesn't make to much of an impact and can be considered very non-urgent.

@reeelix reeelix added the enhancement New feature or request label May 5, 2024
@reeelix
Copy link
Collaborator Author

reeelix commented May 5, 2024

not urgent

@LMH01 LMH01 added the tracking This issue is used to track a specific function or idea but will not be actively worked on label May 5, 2024
@LMH01
Copy link
Owner

LMH01 commented May 5, 2024

Yeah, this option could be removed from the sandbox mode. But as this is not urgent, because it is hidden by default and because the implementation could be a bit of a pain (probably requiring a new argument group) this issue will not be actively worked on for now.

@LMH01
Copy link
Owner

LMH01 commented May 13, 2024

Idea how this could be done. As there is now a new argument group (CheckLoadArgs) this '--disable-instruction-limit' argument could be moved there. This way the argument would no longer applicable to the playground subcommand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tracking This issue is used to track a specific function or idea but will not be actively worked on
Projects
None yet
Development

No branches or pull requests

2 participants