Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap method parameters in a struct in the BLS Aggregator Service #394

Open
damiramirez opened this issue Mar 18, 2025 · 0 comments
Open

Comments

@damiramirez
Copy link
Contributor

damiramirez commented Mar 18, 2025

PR adds a new methods in the BLS Aggregator Service.

  • We should create a struct to store task information such as logger, task_index, aggregated_response_sender, current_aggregated_response, etc. (Check handle_task_expired params)

The following methods receives a large number of parameters, which is why we’re using #[allow(clippy::too_many_arguments)].

  • loop_task_aggregator
  • handle_new_signature
  • build_aggregated_response

The idea is to create a new struct to encapsulate all these parameters.

@damiramirez damiramirez changed the title Wrap handle_task_expired function parameters in a struct Wrap method parameters in a struct in the BLS Aggregator Service Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants