Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test case ut_lind_fs_mmap_unsupported_file #69

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ChinmayShringi
Copy link
Contributor

@ChinmayShringi ChinmayShringi commented Oct 24, 2024

Description

Fixes # (issue)

This PR updates the ut_lind_fs_mmap_unsupported_file test to correctly handle the case where an attempt is made to memory map a directory using the mmap_syscall. Directories are unsupported for memory mapping, and the test now checks whether errno is set to ENODEV (No such device) or EACCES (Permission denied) based on system behavior.

Changes:

  • Modified the test to assert that mmap_syscall returns -1 on failure.
  • Added checks to verify that errno is either ENODEV or EACCES depending on the system’s behavior when attempting to map a directory.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • cargo test ut_lind_fs_mmap_unsupported_file

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

@JustinCappos JustinCappos merged commit d66c2ff into main Oct 24, 2024
1 check failed
@Yaxuan-w Yaxuan-w deleted the fix-ut-lind-fs-mmap-unsupported-file branch October 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants