Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anway shmdt syscall #317

Merged
merged 12 commits into from
Aug 13, 2024
Merged

Anway shmdt syscall #317

merged 12 commits into from
Aug 13, 2024

Conversation

Anway-Agte
Copy link
Contributor

Description

This PR adds test cases and comments for the shmdt and shmat syscalls

Type of change

  • This change adds documentations and tests.

How Has This Been Tested?

  • Test A - ut_lind_fs_shmat_syscall
  • Test B - ut_lind_fs_shmdt_syscall

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

namanlalitnyu
namanlalitnyu suggested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@namanlalitnyu namanlalitnyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor comments.

namanlalitnyu
namanlalitnyu approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@namanlalitnyu namanlalitnyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pranav-bhatt
pranav-bhatt requested changes Jul 29, 2024
View reviewed changes
@rennergade rennergade requested a review from yashaswi2000 July 29, 2024 20:49
yashaswi2000
yashaswi2000 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@yashaswi2000 yashaswi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rennergade
Copy link
Contributor

This has some merge conflicts but once those are resolved this is good to go.

@rennergade rennergade merged commit b78a51c into develop Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashaswi2000 yashaswi2000 yashaswi2000 approved these changes

@pranav-bhatt pranav-bhatt pranav-bhatt approved these changes

@namanlalitnyu namanlalitnyu namanlalitnyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Anway-Agte @rennergade @yashaswi2000 @pranav-bhatt @namanlalitnyu