Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving integration testing with snapshots #150

Open
ataras2 opened this issue Dec 19, 2022 · 0 comments
Open

Improving integration testing with snapshots #150

ataras2 opened this issue Dec 19, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ataras2
Copy link
Collaborator

ataras2 commented Dec 19, 2022

I've noticed that a few of the tests are only checking if not nan or inf.
I understand that for PSF's etc it can be difficult to hard code test cases, but I think there is a middle ground. Snapshot testing (e.g. https://pypi.org/project/pytest-snapshot/) would allow for the current behavior of the package to be saved in typical scenarios, like a dLux airy disk, and for this to be compared to down the track in case internals like wavefront get changed. This also protects us in the sense that if jax changes the way operations are done (or a Windows install goes wrong #145 ), we get a flag to check things manually.
Thoughts?

@ataras2 ataras2 added the enhancement New feature or request label Dec 19, 2022
@ataras2 ataras2 changed the title Improving integration testing Improving integration testing with snapshots Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant