Deployment errors

[clivewalkden]

Hi all,

Just checking if this is happening to other people. During my issue #43 the deployment process was erroring but it didn't stop the process, it simply carried on to the next step and successfully completed with a broken site at the end. Is there a way for the deployer application to send the correct error to the GitHub action to halt the process or is it just me this is not working for?

Thanks, Clive

[seyuf]

Humm, surely there are conditions leading to the bypassing of failed jobs ?
E.g (if: always()):

    - name: 'launch security scanner files'
      if: always()
      uses: MAD-I-T/magento-actions@v3.16
      env:
        COMPOSER_AUTH: ${{secrets.COMPOSER_AUTH}}
      with:
        process: 'security-scan-files'
        elasticsearch: 1

[clivewalkden]

This issue was with the deploy-staging process. Deployer threw an exception but carried on with the next task in the deployment list even though the unpacking of the bucket didn't complete. I would expect a non-zero exit code to stop the running process and mark the deployment failed. Is this expected?

[seyuf]

Nope this is not expected. Nonetheless, your case was pretty particular, explained here. Please try and reproduce the error ? On a clean / fresh env using v3.16 and up? I belive in your case, the php-deployer lost track of the release version and considered that everything when ok. If the error persist we'll do something about it.

[seyuf]

Also feel free to post the content of your workflow / yml file?

[seyuf]

@clivewalkden just tested your scenario (upgrading from v3.11 to 3.18). The right code is sent to github action see here. It's just that the following task must run to cleanup things (i.e the cleanup step). which is the case in my test case the site is not broken but the tracking number is overridden (i.e picture below). So your case, is very strange...

[seyuf]

This should fix this issue ae98c9a

[seyuf]

The set -e was commented in the deployment scripts causing the job to not fail.

[clivewalkden]

Run some further tests and the above change has sorted any issues in the deployment step with it now failing properly. Thank you!

[seyuf]

Great, thanks for the testing.
Best