Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow activating circuit breaker on a specific route only #2111

Open
cbois opened this issue Mar 5, 2025 · 1 comment
Open

Allow activating circuit breaker on a specific route only #2111

cbois opened this issue Mar 5, 2025 · 1 comment

Comments

@cbois
Copy link

cbois commented Mar 5, 2025

Hi!

In previous (v1.4) versions of Otoroshi, it was possible to activate circuit breaker at route (service) level.
Now (v16+), it seems to be possible only at a global scope (in Danger Zone).

Working actually on Load Balancing instances of backends, we have noticed that the HealthChecker uses Circuit Breaker to kick instances of backend that are not healthy.
So we figure out that Circuit Breaker is required to implement this "HA" strategy.

We are not yet comfortable with Circuit Breaker, and we are not ready to activate it globally on our Otoroshi.

Is it possible to restore the capability of activating Circuit Breaker at route level, even if circuit breaker is disabled at a global level?

Thanks!

@mathieuancelin
Copy link
Member

mathieuancelin commented Mar 6, 2025

@cbois We'll talk about it internally next week and we'll get back to you. I'm not in favor of being able to disable circuit breaker in routes as it's intended to be the defaut on purpose. The circuit breaker is default since 2018 in otoroshi with a flag to be able to disable it (because of retro compatibility) and now it's always enabled on purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants