Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding skeleton loading spinner in members page as described in Figma #246

Closed
develad opened this issue Apr 1, 2024 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@develad
Copy link
Contributor

develad commented Apr 1, 2024

Description

Adding skeleton loading spinner in members page as described in Figma

Untitled

Screenshots

No response

Additional information

No response

@develad develad added the enhancement New feature or request label Apr 1, 2024
@develad
Copy link
Contributor Author

develad commented Apr 1, 2024

I will be working on this feature! 💀

@Tamir198
Copy link
Contributor

Tamir198 commented Apr 1, 2024

@develad Hey, please notice that now the project is fetching data from our BAAS repo, not the dummy data.
So for now you will see one item (We have a lot of members so I think it`s ok to show the loader just like in the Figma for now and later on it will fit when we add more data to it)

@develad
Copy link
Contributor Author

develad commented Apr 1, 2024

@develad Hey, please notice that now the project is fetching data from our BAAS repo, not the dummy data. So for now you will see one item (We have a lot of members so I think it`s ok to show the loader just like in the Figma for now and later on it will fit when we add more data to it)

Hi @Tamir198 🖐

I've created a custom SkeletonCards component that can receive by props the number of cards to render on the screen (by default its 6 skeleton cards if not specified otherwise)

Check pull-request #250 for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants