From e97755159d5465bf6daea09a2aa805d9bd87cc46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Thu, 31 Oct 2024 11:49:45 +0100 Subject: [PATCH 1/2] Fix broken link The title has been changed. --- src/project/commands/add/addProject.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/project/commands/add/addProject.ts b/src/project/commands/add/addProject.ts index 8c73453..0d14c0d 100644 --- a/src/project/commands/add/addProject.ts +++ b/src/project/commands/add/addProject.ts @@ -20,7 +20,7 @@ Don't forget to <${getEnvVariable( 'GITLAB_URL' )}/${projectPath}/-/hooks|set up a webhook> \ in your Gitlab project by following the \ -<${HOMER_GIT_URL}/#make-homer-be-notified-of-changes-happening-in-your-gitlab-project|dedicated documentation>. +<${HOMER_GIT_URL}/#1-make-homer-notified-of-changes-happening-in-the-gitlab-project|dedicated documentation>. `, }); } From 3a6d173c223e859a5e7517c4ad2e6661d1d8c984 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Paris?= Date: Thu, 31 Oct 2024 11:50:37 +0100 Subject: [PATCH 2/2] Use proper grammar --- __tests__/project/addProject.test.ts | 2 +- src/project/commands/add/addProjectRequestHandler.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/__tests__/project/addProject.test.ts b/__tests__/project/addProject.test.ts index cb2a298..9a1a449 100644 --- a/__tests__/project/addProject.test.ts +++ b/__tests__/project/addProject.test.ts @@ -125,7 +125,7 @@ describe('project > addProject', () => { expect(response.status).toEqual(HTTP_STATUS_NO_CONTENT); expect(slackBotWebClient.chat.postEphemeral).toHaveBeenNthCalledWith(1, { channel: channelId, - text: expect.stringContaining(`No project match \`${search}\``), + text: expect.stringContaining(`No project matches \`${search}\``), user: userId, }); }); diff --git a/src/project/commands/add/addProjectRequestHandler.ts b/src/project/commands/add/addProjectRequestHandler.ts index 9f6a681..b3192fe 100644 --- a/src/project/commands/add/addProjectRequestHandler.ts +++ b/src/project/commands/add/addProjectRequestHandler.ts @@ -46,7 +46,7 @@ export async function addProjectRequestHandler( await slackBotWebClient.chat.postEphemeral({ channel: channel_id, user: user_id, - text: `No project match \`${query}\` :homer-stressed:`, + text: `No project matches \`${query}\` :homer-stressed:`, }); return; }