Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue on MBDatePicker #411

Open
stefanloerwald opened this issue Mar 1, 2021 · 4 comments
Open

Accessibility issue on MBDatePicker #411

stefanloerwald opened this issue Mar 1, 2021 · 4 comments
Milestone

Comments

@stefanloerwald
Copy link
Collaborator

Lighthouse is reporting an error on my datepicker. It reports the following as having invalid aria attributes:

<div class="mdc-select__anchor mdc-ripple-upgraded" role="button" aria-haspopup="mb_6740ec6c-5c02-45c2-a85e-08611d37e0f1" aria-expanded="false" aria-labelledby="mb_de6ea13c-bbeb-45e9-9322-2caa699d908d mb_8d82c745-6b36-48b0-8605-cb543aa…" tabindex="0" aria-disabled="false">

The date picker I use looks like <MBDatePicker Label="Delivery date", SelectInputStyle="MBSelectInputStyle.Filled" @bind-Value="..." />.

I am not familiar with aria attributes, so don't see why this is invalid.

@MarkStega MarkStega added this to the v2.0.0 milestone Mar 1, 2021
@simonziegler
Copy link
Member

Looks like we need to check the menu markup matches the current MT standard markup. We need to move to MCW v10 in the next month so that's a good time to do it

@simonziegler
Copy link
Member

I just ran lighthouse on both the date picker and select pages and they both show aria errors. Let's get preview 4 released and then make preview 5 about moving to MCW 10.0.0. Once we've completed our QA check of MB markup vs MCW we could consider a broad lighthouse review of MB.

@MarkStega MarkStega modified the milestones: v2.0.0 - Priority A, V2.0.0 - Priority B May 18, 2021
@simonziegler
Copy link
Member

@stefanloerwald can we revisit this please? I'd like to remind myself what's going on and get this resolved.

@MarkStega MarkStega modified the milestones: v2.0.0 - Priority B, v2.0.0 - Priority A Sep 21, 2021
@stefanloerwald
Copy link
Collaborator Author

This is not fixed.

  1. Go to https://material-blazor.com/datepicker
  2. Open dev tools
  3. Go to lighthouse
  4. Select the accessibility report
  5. Observe "aria attributes do not have valid values" warnings

@MarkStega MarkStega modified the milestones: v2.0.0, Backlog Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants