Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin inaccurately sending empty/null data in author array #124

Open
jeffpaul opened this issue Sep 15, 2021 · 1 comment
Open

Plugin inaccurately sending empty/null data in author array #124

jeffpaul opened this issue Sep 15, 2021 · 1 comment
Labels
bug Something isn't working needs discussion
Milestone

Comments

@jeffpaul
Copy link
Contributor

Describe the bug
Somewhere within the changes in #109 and #116 (or potentially elsewhere that I have not accounted for) we introduced the ability to send an array to Sophi of post authors. This presumably takes the WP Core default author and appends whatever other plugins may add as additional authors/bylines (e.g., Co-Authors Plus). It seems that somewhere in these various set up configs that we allow either an empty string or a null reference for an author/byline (I forget specifically how Sophi calls this field) to get passed to Sophi which is then causing the entire data set to be tossed out. We should ensure what we send to Sophi for author/byline does not include an invalid empty string or null reference (though we should ensure we get precise confirmation from the Sophi team on what is / is not permissible on their end before making a change here).

Steps to Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Environment information

  • Device:
  • OS:
  • Browser and version:
  • WordPress version:
  • Plugins and version:
  • Theme and version:
  • Site Health Info:

Additional context

@jeffpaul jeffpaul added bug Something isn't working needs discussion labels Sep 15, 2021
@jeffpaul jeffpaul added this to the 1.0.5 milestone Sep 15, 2021
@jeffpaul jeffpaul modified the milestones: 1.0.5, 1.0.6 Oct 7, 2021
@jeffpaul jeffpaul modified the milestones: 1.0.6, 1.0.7, 1.0.8 Oct 28, 2021
@jeffpaul jeffpaul modified the milestones: 1.0.8, 1.1.0 Jan 4, 2022
@jeffpaul jeffpaul modified the milestones: 1.0.10, 1.1.0 Feb 28, 2022
@jeffpaul jeffpaul modified the milestones: 1.3.0, 1.4.0 Sep 27, 2022
@jeffpaul
Copy link
Contributor Author

jeffpaul commented Jan 3, 2023

@YMufleh is this update still needed or does the content processing on the Sophi side of things adequately handle for this and thus mean we can close out this request on the plugin side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs discussion
Projects
None yet
Development

No branches or pull requests

1 participant