Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW05 is ready for grading #4

Open
Mathnstein opened this issue Oct 21, 2017 · 3 comments
Open

HW05 is ready for grading #4

Mathnstein opened this issue Oct 21, 2017 · 3 comments

Comments

@Mathnstein
Copy link
Owner

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho

@vibudh2209
Copy link
Collaborator

Hi
Whatever is done is done wonderfully.

  • Starting with repo easy to read
  • Most of the factor management part done wonderfully
  • Saving ggplot using ggsave
  • Home page with homework links (Except homework 5)

Few comments:

  • Firstly you missed the homework link for 5th homework on the home page (Just add it 😄 )
  • It would have been a good idea to provide markdown file along with rmd and pdf files.
  • Starting with task 1, its done very efficiently and each step is shown and explained clearly (in both removing Oceania and along with its level)
  • Reordering of factors is also done wonderfully along with the proper explanation of difference between arrange and fct_reorder (mean, max is used for reorder which is more than expected!!!)
  • In the I/O part it would have been better to show how factor order is retained in RDS and txt while lost in csv
  • I guess you missed the visualization part here is the link to class note, you can go through it and try, its not very difficult
  • ggsave has been done but could have been done with few more examples showing how different arguments affect the saved plot, along with when is it necessary to give which image to save and also pdf did not show the saved image (try to first save the image on github and then provide that link on the markdown)
  • Finally it would have been great with a brief paragraph about whats easy and what not

Overall decent work is done its clear you are an expert in factor management but may want to work little bit on ggplot

Cheers
Vibudh

@auduman
Copy link
Collaborator

auduman commented Oct 25, 2017

Hi @Mathnstein!

Awesome homework 5. It's clear that you understand factor management and reordering!

  • Your dropping of Oceania was done well, it was very clear what steps you took and your code was easy to understand.

  • Your factor reordering was done well also, I especially like how you tried different variables like max and gdpPercap to see if anything interesting results in the output.

  • Good job exploring why arrange() didn't result in a change in the ggplot - and checking if your results made sense!

  • File I/O was done well, one suggestion would be to try a few different options instead of just .csv to see if there is any difference between the two (e.g. factor reordering). I like how you tested if the arrange survived the process!

  • Writing figures to file: also done well, this was a fairly basic task. One suggestion would be to use different arguments to apply to the saved image, and see what the result is?

  • One suggestion would be to include the visualization section, where you can improve a previously made graph from an older homework given what we've learned recently in ggplot2.

One suggestion I would have is to have a .md version of your homework in your repo to make it easier for the peer reviewer to read (without having to open R).

Overall, great job! You just missed the visualization part, not sure if that was intentional or not :)

Cheers,
Aisha

@derekcho
Copy link

Hi @Mathnstein, here are some comments about your hw05:

  • The first part of the assignment was well done. You were able to successfully drop Oceania and its associated countries from gapminder. You can show the levels of continent using levels() rather than summary()
  • Factor reordering was also well done. You produced good plots that show the effects of reordering and arranging on a plot
  • For file I/O, you should mention that write_csv does not preserve factor levels
  • Your plots for the above section are well done, but you should produce new plots for the visualization design section rather than reusing those
  • I did not find a progress report

Your grade will be emailed to you at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants