Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW06 is ready for grading #5

Open
Mathnstein opened this issue Nov 7, 2017 · 3 comments
Open

HW06 is ready for grading #5

Mathnstein opened this issue Nov 7, 2017 · 3 comments

Comments

@Mathnstein
Copy link
Owner

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho

@AnhKhoaVo
Copy link

Hi @Mathnstein ,

What I like: It was a pleasure reading your homework 6 since it was so easy to read and follow what you have put down in there. I also enjoyed the .pdf file for the ease of reading. I also like how you repeat the question to for us to know what you answer to.

What needs improvement: I believe if you pick question 1 (stringr exercise), you are required to do 1 questions out of 13 exercises in the stringr chapter. Meaning you need to do 13 codes in total.

  1. Coding style: I find your coding style easy to follow, especially for someone who has limited experience in R. +

  2. Coding strategy: I enjoy your coding strategy since I am able to follow it naturally in a logical sense. +

Overall, I quite enjoyed your homework.

@heathersummers
Copy link
Collaborator

Hi,

Overall your repository is well laid out and I found it easy to find your homework 6 assignment using the link in your README.md file. The commenting throughout the assignment made it very easy to follow the code. For the first part of the assignment where you worked through the exercises in the Strings chapter the answers to each of the questions were well explained and included examples to support the answer. You created a detailed cheat sheet of the stringr package and I have found it very helpful reviewing your assignment and look forward to using some of the stringr functions and characters to tidy data. For the second part of the assignment where you worked with a list was very well done. For some of the lines of code I would suggest maybe adding a little more explanation of what the functions are doing to make it easier on the reviewer to follow along (especially since the output of the code is not included). Lastly, your reflection on your process was detailed and included areas of the assignment that you found easy (i.e. purr functions) and others that you found more difficult and would benefit from more of an explanation (i.e. grouping and backreferencing). Overall, amazing job on this assignment and best of luck with future assignments.

Heather

@derekcho
Copy link

Hi @Mathnstein ! Here are some comments about your hw06:

  • Your first task was done well! You provided good explanations and answered the questions correctly. Nice work incorporating error checking into your function but perhaps you can call it something other than my_func().
  • For your second task (working with a list), it was done pretty well but I think that it could benefit from a bit more explanation in a few places. For example, when you show the output of matches, what do those numbers correspond to? Same goes for match_length.
  • Overall, your report was well organized and your coding was efficient and easy to read. You were able to complete the tasks successfully but I think that it could benefit from more detailed explanations. I marked your .pdf file for this assignment, I am guessing that you had trouble knitting a .md file if you attempted the first question. Nice work overall!

Note: your mark (check minus, check, check plus) will be distributed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants