-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hw 07 is ready for grading #6
Comments
Hi! @Mathnstein Thank you for inviting me on your GitHub. Here's my peer review for Homework 07. Hopefully you find these comments helpful! Your repository is very organized. Your README file in your HW repository was easy to navigate with the links for each homework session. The README file in your hw07 is also very informative, you explained each of the R scripts well with proper links to each of them. You also explained the input and output of each of the R scripts, so it is very easy to understand how your pipeline works! Good job! I tried to run your pipeline and it seems to work well. Your master R script properly Also, in Another suggestion might be you can also try to automate the pipeline with a Makefile, it is equivalent to your master R script, but different format, it is good for your practice! Overall, this is a good assignment, I hope you keep enjoying this class :) |
Hi! @Mathnstein, Good job, your repo looks very neat and your readme file is well structured. It is easy to explore and there are many links to access the files, and you even explained the tasks on each scripts. However, there is no need to add your report in the README file since you already get the hw07.pdf. Here're more specific comments on each scripts. You did a great job on 01_exploratory.R and 00_downloader.R, I noticed you draw two plots and save them, but you didn't mention all of them in your report. In 02_statistical.R, you used the clean data set, but you forgot to check again to make sure your new continent order is still in force, and also fit a linear regression of life expectancy on year within each country. You could use broom() to finish the second task. Other than those points, well done. Your report is well organized, and I really like your master file, because I wrote a Makefile for the pipeline and it's extremely long, may be I will try your way next time. I think you demonstrate an in depth understanding of pipeline and R scripts. |
Hi @Mathnstein! Here are some comments about your hw07: Three or more scripts, an Rmd, and a Makefile: Yes
Note: your mark (check minus, check, check plus) will be distributed later. |
@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho
The text was updated successfully, but these errors were encountered: