Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw 07 is ready for grading #6

Open
Mathnstein opened this issue Nov 16, 2017 · 3 comments
Open

Hw 07 is ready for grading #6

Mathnstein opened this issue Nov 16, 2017 · 3 comments

Comments

@Mathnstein
Copy link
Owner

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho

@hannahdxz
Copy link

hannahdxz commented Nov 17, 2017

Hi! @Mathnstein

Thank you for inviting me on your GitHub. Here's my peer review for Homework 07. Hopefully you find these comments helpful!

Your repository is very organized. Your README file in your HW repository was easy to navigate with the links for each homework session. The README file in your hw07 is also very informative, you explained each of the R scripts well with proper links to each of them. You also explained the input and output of each of the R scripts, so it is very easy to understand how your pipeline works! Good job!

I tried to run your pipeline and it seems to work well. Your master R script properly source() the 3 R scripts. One thing I noticed is that in 02_statistical.R, you did not check if your new continent order from the previous R script is still in force when you read in the data, since as I remember, write.table() and read.table() does not preserve your work in the previous script where you reordered the data. Instead, you can try saveRDS() and readRDS(), it will save the reordered continent level when you write to file then read back in.

Also, in 02_statistical.R you can try to fit a linear regression of life expectancy on year within each country, and write the estimated intercepts, slopes, and residual error variance (or sd) to file. Here is a detailed tutorial about this task.

Another suggestion might be you can also try to automate the pipeline with a Makefile, it is equivalent to your master R script, but different format, it is good for your practice!

Overall, this is a good assignment, I hope you keep enjoying this class :)

@wenzhengzzz
Copy link

Hi! @Mathnstein

Good job, your repo looks very neat and your readme file is well structured. It is easy to explore and there are many links to access the files, and you even explained the tasks on each scripts. However, there is no need to add your report in the README file since you already get the hw07.pdf. Here're more specific comments on each scripts.

You did a great job on 01_exploratory.R and 00_downloader.R, I noticed you draw two plots and save them, but you didn't mention all of them in your report.

In 02_statistical.R, you used the clean data set, but you forgot to check again to make sure your new continent order is still in force, and also fit a linear regression of life expectancy on year within each country. You could use broom() to finish the second task.

Other than those points, well done. Your report is well organized, and I really like your master file, because I wrote a Makefile for the pipeline and it's extremely long, may be I will try your way next time. I think you demonstrate an in depth understanding of pipeline and R scripts.

@derekcho
Copy link

derekcho commented Dec 4, 2017

Hi @Mathnstein! Here are some comments about your hw07:

Three or more scripts, an Rmd, and a Makefile: Yes
Starts by downloading data, ends with Rmd: No
The output of each is the modified input of the previous step: Yes
Includes some analysis and at least one figure: Yes
Makefile includes all scripts and Rmd with correct dependencies: N/A
Makefile runs: Yes (master.R)

  • Your master R script is good except it is missing a line that renders your Rmarkdown document. I was able to download and run your scripts without any issues
  • Your exploratory analysis is decent, although you want to include these plots and comments in your markdown file rather than just leaving them here! You produced two plots and successfully reordered the levels of continents from gapminder
  • You provided plots of life expectancy against year for each continent but you could have added some kind of statistical analysis as well (like linear regression). In addition, you can try to filter the plots so that you only show the 3 or 4 best/worst countries for each continent. These should have been displayed in your Rmd as well (rather than just one)
  • I did not find a progress report for this assignment

Note: your mark (check minus, check, check plus) will be distributed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants