Hw 09 ready for grading

[Mathnstein]

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho

[yuanjisun]

Hello @Mathnstein,

I appreciate your good job. Here are my comments.

Pros

1. All tests in testthat() are passed successfully.
2. After running check, there is no error. Great!
3. Your license and description are done in a correct way.
4. Great test files. You used expect_false(), expect_error() and expect_identical() to exam the functions under different situations. Both positive and negative tests are done.
5. All functions were exported successfully.
6. I checked your package by running functions and all of them worked.

Cons

1. It would be better to add more information about this package (such as how to install it, what is each function for) in README.
2. There is no package documentation when running the code ?powers.
3. Your repo is confusing. There is one folder called Hw09 and another one called "HW09`. Maybe you want to remove one of them.

Congratulations on your good job!

Yuanji

[arsbar24]

Hi Cody,

I found your choice of functions complex and imaginative. They considerably increase the power of the package. Now that I’ve got the puns out of my system:

• Your work was functional and cleanly written with an original idea (I liked the expform function’s use of strings to output improved notation).

• I would’ve named the modulus function something else, as originally I had it mixed up with the modulus function we defined in class (modular arithmetic).

• To further develop this package, it would’ve been cool if you used to expform() function to modify the cube, square and power functions for complex numbers (maybe using an inverse expform() as well).

• Like Yuanji, I found your repo a bit confusing with the folders HW09 and Hw09.

It's a well-done assignment. Congratulations on finishing the course (I see your HW10 is already done).

Keep it real,
Alistair

[derekcho]

Hi @Mathnstein, here are some comments about your hw09:

Able to install properly: Yes
At least one new function: Yes
Used assertions to check function input: No
Documented exported functions: Yes
Includes three unit tests for each function: Yes
Passes check: Yes
README and vignette: Yes
Reflections included: Yes (a little short though)

• You should leave some instructions on how to install your package in the README
• I was able to download and install your package without any problems
• Repo can use a little cleanup, you have two folders for hw09
• Vignette is included but lacks details on the purpose of each function. For some functions it is obvious what they do, but not so much for others such as argument and modulus
• Good work overall, your package runs smoothly!

Your grade will be emailed to you at a later date.