From 52ca7ea742a55851ff19228f6fe14dae9bd0ea84 Mon Sep 17 00:00:00 2001 From: James Bruten Date: Tue, 28 Jan 2025 10:59:40 +0000 Subject: [PATCH 1/3] add rose edit and ancils guidance --- source/WorkingPractices/approvals.rst | 4 ++++ source/WorkingPractices/inputs.rst | 11 ++++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/source/WorkingPractices/approvals.rst b/source/WorkingPractices/approvals.rst index 7fba50f..bf267a3 100644 --- a/source/WorkingPractices/approvals.rst +++ b/source/WorkingPractices/approvals.rst @@ -23,6 +23,10 @@ off the approval. code owners is available and they should still be consulted as part of your development. +.. important:: + + New UM Ancils must be submitted the the MIAO team for approval. Please follow their process for `Requesting New UM Ancils `_. + Code Owners ----------- Every file in the codebases has a :ref:`code_owner`, and every file changed diff --git a/source/WorkingPractices/inputs.rst b/source/WorkingPractices/inputs.rst index 5ead1b6..a8b328f 100644 --- a/source/WorkingPractices/inputs.rst +++ b/source/WorkingPractices/inputs.rst @@ -2,6 +2,11 @@ Input Variables, Rose Metadata and Upgrade Macros ================================================= + +.. important:: + + New UM Ancils must be submitted the the MIAO team for approval. Please follow their process for `Requesting New UM Ancils `_. + Sometimes the developer needs to alter model namelists and input variables. A common reason is for the inclusion of a new piece of code which has to be turned off by default. @@ -73,13 +78,13 @@ to the new metadata. The SSD team are also available to advise on whether an upg rose edit -C rose-stem/app/APP-NAME - For LFRic Apps a few extra changes are required: + For LFRic Apps a few extra changes are required. In your branch (your test branch if you have an upgrade macro): .. code-block:: export ROSE_PYTHONPATH=$PYTHONPATH - export ROSE_META_PATH=/path/to/valid/core - rose edit -C rose-stem/app/APP-NAME + export ROSE_META_PATH=/path/to/valid/core:/path/to/apps/copy + rose edit -C rose-stem/app/APP-NAME --no-warn version This requires an LFRic Core working copy at an appropriate revision to be available. It is also necessary to run from the top level of the Apps working copy to ensure rose metadata paths are valid. From 5ca2968396faa2f417f3093986ac2f7ac0e18519 Mon Sep 17 00:00:00 2001 From: James Bruten <109733895+james-bruten-mo@users.noreply.github.com> Date: Mon, 3 Feb 2025 11:18:55 +0000 Subject: [PATCH 2/3] Update source/WorkingPractices/approvals.rst Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com> --- source/WorkingPractices/approvals.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/WorkingPractices/approvals.rst b/source/WorkingPractices/approvals.rst index bf267a3..b7e6590 100644 --- a/source/WorkingPractices/approvals.rst +++ b/source/WorkingPractices/approvals.rst @@ -25,7 +25,7 @@ off the approval. .. important:: - New UM Ancils must be submitted the the MIAO team for approval. Please follow their process for `Requesting New UM Ancils `_. + New UM Ancils must be submitted to the MIAO team for approval. Please follow their process for `Requesting New UM Ancils `_. Code Owners ----------- From 7404109fd61299d2d6e8a16831414b582e1c27e8 Mon Sep 17 00:00:00 2001 From: James Bruten <109733895+james-bruten-mo@users.noreply.github.com> Date: Mon, 3 Feb 2025 11:18:59 +0000 Subject: [PATCH 3/3] Update source/WorkingPractices/inputs.rst Co-authored-by: Jenny Hickson <61183013+jennyhickson@users.noreply.github.com> --- source/WorkingPractices/inputs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/WorkingPractices/inputs.rst b/source/WorkingPractices/inputs.rst index a8b328f..5481db1 100644 --- a/source/WorkingPractices/inputs.rst +++ b/source/WorkingPractices/inputs.rst @@ -5,7 +5,7 @@ Input Variables, Rose Metadata and Upgrade Macros .. important:: - New UM Ancils must be submitted the the MIAO team for approval. Please follow their process for `Requesting New UM Ancils `_. + New UM Ancils must be submitted to the MIAO team for approval. Please follow their process for `Requesting New UM Ancils `_. Sometimes the developer needs to alter model namelists and input variables. A common reason is for the inclusion of a new piece of code which has to be