Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyringController does not prevent duplicate accounts properly #5411

Open
mikesposito opened this issue Feb 28, 2025 · 0 comments
Open

KeyringController does not prevent duplicate accounts properly #5411

mikesposito opened this issue Feb 28, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@mikesposito
Copy link
Member

Current checks for duplicate accounts do not work properly since support for multiple HD keyrings has been added. Moreover, there are several loopholes in the current method in charge of checking duplicates:

  • No keyring is checked besides the simple one
  • No check is made when adding an account (only when creating the keyring)

The issue can be dangerous because of several selectors that allow picking a keyring based on an account included in it: this can lead to targeting the wrong keyring because of the address belonging to multiple ones (e.g. primary keyring removed instead of the second one)

@mikesposito mikesposito added the bug Something isn't working label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant