Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Synchronously initialise WASM modules #2024

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Dec 8, 2023

When the experimental.wasm flag in the Snaps CLI is enabled, the WASM module will now be synchronously initialised, rather than being inlined as a Uint8Array.

For example, if the WASM module exports a fibonacci function, the following is now possible:

import { fibonacci } from './path/to/file.wasm';

fibonacci(...);

This is a breaking change, because previously the WASM module would be inlined as Uint8Array instead.

@Mrtenz Mrtenz requested a review from a team as a code owner December 8, 2023 10:53
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57d8a53) 96.08% compared to head (daafb31) 96.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2024      +/-   ##
==========================================
+ Coverage   96.08%   96.10%   +0.01%     
==========================================
  Files         269      269              
  Lines        6262     6286      +24     
  Branches     1010     1011       +1     
==========================================
+ Hits         6017     6041      +24     
  Misses        245      245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz merged commit cd57539 into main Dec 13, 2023
141 checks passed
@Mrtenz Mrtenz deleted the mrtenz/sync-wasm branch December 13, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants