From 6395c061ac28cf5f17403135c421d626e19bb302 Mon Sep 17 00:00:00 2001 From: Michel Mendiola Date: Mon, 18 Dec 2023 12:44:11 -0600 Subject: [PATCH] - Fix setting for allowFullScreen - Don't need to parse new lines and spaces Signed-off-by: Michel Mendiola --- OharaYTEmbed.xml | 2 +- Sources/OharaYTEmbed.php | 10 +++------- Themes/default/languages/OharaYTEmbed.english-utf8.php | 2 +- Themes/default/languages/OharaYTEmbed.polish.php | 2 +- .../default/languages/OharaYTEmbed.spanish_es-utf8.php | 2 +- Themes/default/languages/OharaYTEmbed.spanish_es.php | 2 +- .../languages/OharaYTEmbed.spanish_latin-utf8.php | 2 +- .../default/languages/OharaYTEmbed.spanish_latin.php | 2 +- Themes/default/scripts/ohyoutube.js | 6 +++--- addHooks.php | 2 +- package-info.xml | 2 +- readme.txt | 5 +++++ 12 files changed, 20 insertions(+), 19 deletions(-) diff --git a/OharaYTEmbed.xml b/OharaYTEmbed.xml index 1b1edf6..df68733 100644 --- a/OharaYTEmbed.xml +++ b/OharaYTEmbed.xml @@ -3,7 +3,7 @@ Suki:ohara_youtube_embed - 1.2.14 + 1.2.15 diff --git a/Sources/OharaYTEmbed.php b/Sources/OharaYTEmbed.php index abc20ff..187d838 100644 --- a/Sources/OharaYTEmbed.php +++ b/Sources/OharaYTEmbed.php @@ -2,7 +2,7 @@ /* * @package Ohara Youtube Embed mod - * @version 1.2.14 + * @version 1.2.15 * @author Michel Mendiola * @copyright Copyright (C) 2023 Michel Mendiola * @license http://www.mozilla.org/MPL/ MPL 2.0 @@ -175,18 +175,14 @@ function OYTE_Main($data) // Got something! else $result = ' - '; + '; return $result; } function OYTE_Vimeo($data) { - global $modSettings, $txt, $sourcedir; + global $modSettings, $txt; if (empty($data) || empty($modSettings['OYTE_master'])) return sprintf($txt['OYTE_unvalid_link'], 'vimeo'); diff --git a/Themes/default/languages/OharaYTEmbed.english-utf8.php b/Themes/default/languages/OharaYTEmbed.english-utf8.php index 6b3dc87..37cd84e 100644 --- a/Themes/default/languages/OharaYTEmbed.english-utf8.php +++ b/Themes/default/languages/OharaYTEmbed.english-utf8.php @@ -2,7 +2,7 @@ /* * @package Ohara Youtube Embed mod - * @version 1.2.14 + * @version 1.2.15 * @author Michel Mendiola * @copyright Copyright (C) 2022 Michel Mendiola * @license http://www.mozilla.org/MPL/ MPL 2.0 diff --git a/Themes/default/languages/OharaYTEmbed.polish.php b/Themes/default/languages/OharaYTEmbed.polish.php index 24e43b0..db6520b 100644 --- a/Themes/default/languages/OharaYTEmbed.polish.php +++ b/Themes/default/languages/OharaYTEmbed.polish.php @@ -2,7 +2,7 @@ /* * @package Ohara Youtube Embed mod - * @version 1.2.14 + * @version 1.2.15 * @author Michel Mendiola * @copyright Copyright (C) 2022 Michel Mendiola * @license http://www.mozilla.org/MPL/ MPL 2.0 diff --git a/Themes/default/languages/OharaYTEmbed.spanish_es-utf8.php b/Themes/default/languages/OharaYTEmbed.spanish_es-utf8.php index 324c767..f4eda18 100644 --- a/Themes/default/languages/OharaYTEmbed.spanish_es-utf8.php +++ b/Themes/default/languages/OharaYTEmbed.spanish_es-utf8.php @@ -2,7 +2,7 @@ /* * @package Ohara Youtube Embed mod - * @version 1.2.14 + * @version 1.2.15 * @author Michel Mendiola * @copyright Copyright (C) 2022 Michel Mendiola * @license http://www.mozilla.org/MPL/ MPL 2.0 diff --git a/Themes/default/languages/OharaYTEmbed.spanish_es.php b/Themes/default/languages/OharaYTEmbed.spanish_es.php index 3ec02e7..42a39e1 100644 --- a/Themes/default/languages/OharaYTEmbed.spanish_es.php +++ b/Themes/default/languages/OharaYTEmbed.spanish_es.php @@ -2,7 +2,7 @@ /* * @package Ohara Youtube Embed mod - * @version 1.2.14 + * @version 1.2.15 * @author Michel Mendiola * @copyright Copyright (C) 2022 Michel Mendiola * @license http://www.mozilla.org/MPL/ MPL 2.0 diff --git a/Themes/default/languages/OharaYTEmbed.spanish_latin-utf8.php b/Themes/default/languages/OharaYTEmbed.spanish_latin-utf8.php index 6aebc99..2d2d671 100644 --- a/Themes/default/languages/OharaYTEmbed.spanish_latin-utf8.php +++ b/Themes/default/languages/OharaYTEmbed.spanish_latin-utf8.php @@ -2,7 +2,7 @@ /* * @package Ohara Youtube Embed mod - * @version 1.2.14 + * @version 1.2.15 * @author Jessica González * @copyright Copyright (C) 2020 Jessica González * @license http://www.mozilla.org/MPL/ MPL 2.0 diff --git a/Themes/default/languages/OharaYTEmbed.spanish_latin.php b/Themes/default/languages/OharaYTEmbed.spanish_latin.php index 3ec02e7..42a39e1 100644 --- a/Themes/default/languages/OharaYTEmbed.spanish_latin.php +++ b/Themes/default/languages/OharaYTEmbed.spanish_latin.php @@ -2,7 +2,7 @@ /* * @package Ohara Youtube Embed mod - * @version 1.2.14 + * @version 1.2.15 * @author Michel Mendiola * @copyright Copyright (C) 2022 Michel Mendiola * @license http://www.mozilla.org/MPL/ MPL 2.0 diff --git a/Themes/default/scripts/ohyoutube.js b/Themes/default/scripts/ohyoutube.js index 0485c6f..21a4505 100644 --- a/Themes/default/scripts/ohyoutube.js +++ b/Themes/default/scripts/ohyoutube.js @@ -1,7 +1,7 @@ /* Copyright (C) 2022 Michel Mendiola @license http://www.mozilla.org/MPL/ MPL 2.0 - @version 1.2.13 + @version 1.2.15 */ class OharaYouTubeEmbed { @@ -42,11 +42,11 @@ class OharaYouTubeEmbed { addIframe(element) { let iframe = document.createElement('iframe') - let iframeUrl = '//www.youtube.com/embed/' + element.videoID + '?autoplay=1&autohide=1'; + let iframeUrl = 'https://www.youtube.com/embed/' + element.videoID + '?autoplay=1&autohide=1'; iframe.frameBorder = '0' iframe.src = iframeUrl - iframe.allowfullscreen = 'allowfullscreen' + iframe.setAttribute('allowFullScreen', '') element.append(iframe) } diff --git a/addHooks.php b/addHooks.php index 626bd20..8b96997 100644 --- a/addHooks.php +++ b/addHooks.php @@ -2,7 +2,7 @@ /* * @package Ohara Youtube Embed mod - * @version 1.2.14 + * @version 1.2.15 * @author Michel Mendiola * @copyright Copyright (C) 2022 Michel Mendiola * @license http://www.mozilla.org/MPL/ MPL 2.0 diff --git a/package-info.xml b/package-info.xml index 2191bed..e9a50cd 100644 --- a/package-info.xml +++ b/package-info.xml @@ -5,7 +5,7 @@ Ohara YouTube Embed Suki:ohara_youtube_embed - 1.2.14 + 1.2.15 modification diff --git a/readme.txt b/readme.txt index 1b5f4be..a25ae3d 100644 --- a/readme.txt +++ b/readme.txt @@ -52,6 +52,11 @@ file, You can obtain one at http://mozilla.org/MPL/2.0/. [color=purple][b][size=12pt]Changelog[/size][/b][/color] [code] +1.2.15 - Dec 18, 2023 +- Fix setting for allowFullScreen +- Don't need to parse new lines and spaces +- Add phpunit tests + 1.2.14 - May 06, 2023 - Remove imgur support - Fix correctly displaying smileys after posting a video