-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigating directly to a page leads to a 404 #25
Comments
the reason this happens is because there is no context to opening the file. this means that It can't be opened because it should not even be ready. |
you mean like this? https://stackoverflow.com/questions/46056414/getting-404-for-links-with-create-react-app-deployed-to-github-pages#46060999 or https://create-react-app.dev/docs/deployment/#serving-apps-with-client-side-routing
|
switching from universal-router to https://github.com/mksarge/redux-json-router#usage may also fix this and provide additional benefits like allowing for a wildcard route path that can lead to a custom classclock-style 404 page on invalid routes. |
This is fixed in the dev branch and will be part of the next release |
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Either settings page should be visible if you have already selected a school or you should see a prompt to select a school.
Actual behavior
404 Error
this seems to be an issue with the redux-first routing model that classclock uses.
this card on the roadmap partly references this problem, but is also combined with the issue of needing to automate builds
The text was updated successfully, but these errors were encountered: