From 6644032649bd0cc7aee33093f2a774854aa51290 Mon Sep 17 00:00:00 2001 From: John Shaughnessy Date: Thu, 7 Mar 2024 13:22:37 -0500 Subject: [PATCH] Fix the generated filename for pdfs --- extension/popup/memory_cache.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/extension/popup/memory_cache.js b/extension/popup/memory_cache.js index d6a4da1..f76db5a 100644 --- a/extension/popup/memory_cache.js +++ b/extension/popup/memory_cache.js @@ -16,7 +16,16 @@ async function generateFileName(ext) { } }) .then ((fileName)=> { - return fileName.replaceAll(":",""); + return fileName.replaceAll(":","") + .replaceAll("!","") + .replaceAll("?","") + .replaceAll("/","") + .replaceAll("\\","") + .replaceAll("*","") + .replaceAll("|","") + .replaceAll(" ","") + .replaceAll("<","") + .replaceAll(">",""); }) .catch((error) => { reject(`Error querying tabs: ${error}`); @@ -34,7 +43,7 @@ async function savePDF() { // Fallback to non-silent mode. await browser.tabs.saveAsPDF({ // Omit the DOWNLOAD_SUBDIRECTORY prefix because saveAsPDF will not respect it. - toFileName: `PAGE-${generateFileName("pdf")}`, + toFileName: `PAGE-${await generateFileName("pdf")}`, }); } }