Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-nanosecond datetime #682

Closed
kafitzgerald opened this issue Jan 29, 2025 · 1 comment · Fixed by #691
Closed

Support for non-nanosecond datetime #682

kafitzgerald opened this issue Jan 29, 2025 · 1 comment · Fixed by #691
Assignees
Milestone

Comments

@kafitzgerald
Copy link
Contributor

kafitzgerald commented Jan 29, 2025

In short, the broader ecosystem is working to support non-nanosecond datetime objects (see: pydata/xarray#7493) in Pandas 2+ and Xarray's release last month. This topic was brought to my attention by the recent upstream dev issues w/ Xarray (#681).

As I was digging through our climatology code today, I noticed we have some things hard coded that will break (in some cases) with these ecosystem changes.

We'll likely want to pin some dependencies and/or make changes and add tests to support this.

Related:

@kafitzgerald
Copy link
Contributor Author

kafitzgerald commented Feb 7, 2025

It looks like we already have versions of these packages with support for non-nanosecond datetimes installing in our test environments. Our tests aren't failing, but I suspect that's because we're not testing for this.

_infer_calendar_name and the test suite are probably where changes are needed.

Also worth noting that there's some overlap here with #508.

@kafitzgerald kafitzgerald self-assigned this Feb 7, 2025
@kafitzgerald kafitzgerald added this to the v2025.02.0 milestone Feb 20, 2025
@anissa111 anissa111 mentioned this issue Feb 25, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant