Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing properties and data outside of the context manager #24

Closed
bnlawrence opened this issue Jan 8, 2025 · 3 comments
Closed

Accessing properties and data outside of the context manager #24

bnlawrence opened this issue Jan 8, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@bnlawrence
Copy link
Collaborator

We currently believe that it is important for thread safety that not all threads share the same open file. We also currently believe that h5netcdf needs the file open to do anything with an h5netdf variable. While we want that to change, our current workaround will be to allow h5netcdf users with pyfive backends to get access to a pyfive variable instance for data access.

The expected usage needs a test and support within h5d.

This issue has arisen as part of David's tests in #21

@bnlawrence bnlawrence added the enhancement New feature or request label Jan 8, 2025
@bnlawrence bnlawrence added this to the h5netcdf ready milestone Jan 8, 2025
@bnlawrence bnlawrence self-assigned this Jan 8, 2025
@bnlawrence
Copy link
Collaborator Author

@davidhassell If you could see if this solves your problems, and if it does, we can close this issue. All tests pass, including the new one (which failed for data access before adding this).

@bnlawrence
Copy link
Collaborator Author

(The commit above included some pseudo chunking stuff that leaked in from another branch, I removed it in 34a684a)

@bnlawrence
Copy link
Collaborator Author

I think the new tests show this work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant