Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Comment Feedback for: date of type Quantity or string on all FHIR entities #76

Closed
teslajoy opened this issue Nov 11, 2024 · 3 comments
Assignees
Labels
Biospecimen Module Tasks or issues related to the Biospecimen Module Family Module Tasks or issues related to the Family Module File/File Metadata Module Tasks or issues related to the File/File Metadata Module Phenotype/Condition Module Tasks or issues related to the Phenotype/Condition Module Research Study Module Tasks or issues related to the Research Study Module

Comments

@teslajoy
Copy link
Collaborator

What were you reviewing?

All FHIR resource entities

Suggested Improvements:

Enable one to many date of type Quantity or string on all entities. Example:

  • dateQuantity -> Quantity integer with unit definitions ex. days
  • dateString -> string representing a date (could place restrictions on how this string may be validated as date. ex. ^\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12]\d|3[01])$)

further examples in research:

  • Specimen
    • Index collection date days
    • Index run date days
  • Condition or Patient/Participant
    • Days to last followup
  • Patient/Participant
    • Days to death
@teslajoy teslajoy changed the title General Feedback - date of type Quantity or string on all FHIR entities For Comment Feedback for: date of type Quantity or string on all FHIR entities Nov 14, 2024
@JamedFV JamedFV added Participant Module Tasks or issues related to the Participant Module File/File Metadata Module Tasks or issues related to the File/File Metadata Module Phenotype/Condition Module Tasks or issues related to the Phenotype/Condition Module Research Study Module Tasks or issues related to the Research Study Module Family Module Tasks or issues related to the Family Module Biospecimen Module Tasks or issues related to the Biospecimen Module and removed Participant Module Tasks or issues related to the Participant Module labels Nov 15, 2024
@RobertJCarroll
Copy link
Contributor

Thanks for this comment. I think we need to look into making a couple of things more clear:

  1. The use of relativeDateTime to allow use of "time quantities" (this exists already, but it may not be clear). This already exists everywhere we have dates (as a standard FHIR extension), but it likely isn't clear.
  2. Some of these features, eg, age at death and age at follow up, do have specific homes.

@teslajoy
Copy link
Collaborator Author

teslajoy commented Jan 6, 2025

Hi - we can possibly close this and follow through #83 on temporal data mappings.

@JamedFV
Copy link
Collaborator

JamedFV commented Jan 6, 2025

Sounds good @teslajoy -- closing this out now

@JamedFV JamedFV closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Biospecimen Module Tasks or issues related to the Biospecimen Module Family Module Tasks or issues related to the Family Module File/File Metadata Module Tasks or issues related to the File/File Metadata Module Phenotype/Condition Module Tasks or issues related to the Phenotype/Condition Module Research Study Module Tasks or issues related to the Research Study Module
Projects
None yet
Development

No branches or pull requests

3 participants