orange to points partition

Pull Request Summary

Change the orange to points partition OASIS decomposition for regular and curvilinear grids.

Description

The current OASIS decomposition for regular and curvilinear grids is 'orange', described by a global offset and a local extent. The local extent in the case of WAVEWATCHIII is always equal to 1. In this situation, it is more natural to describe the OASIS decomposition as a points partition. Furthermore, the orange partition has a limitation of 200 segments, while the points partition can have any number of segments. The code was reviewed to remove unnecessary variables and to deallocate vectors once they are no longer needed.

There is no change of answers expected, as the OASIS decomposition will be the same but described in a different way. Please refer to the OASIS manual for details on OASIS partitioning.

Lables that could be added: enhancement

Issue(s) addressed

• fixes Orange to points partition OASIS decomposition #1360

Commit Message

Change the orange to points partition OASIS decomposition

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

Changes are fully covered by the ww3_tp2.14 regression tests, as the changes proposed only affect OASIS coupling.
Regression tests have been run on the Met Office XC40 machine using the gnu compiler.
No changes in the regression tests are expected.