Issue with building WW3 under UFS Coastal

[uturuncoglu]

Describe the bug
The model does not build cleanly under UFS Coastal and giving error related with the PIO library.

To Reproduce

• git clone --recursive https://github.com/oceanmodeling/ufs-weather-model.git
• cd ufs-weather-model/tests
• BUILD_JOBS=1 ./compile.sh "hercules" "-DAPP=CSTLW -DPDLIB=ON -DBUILD_TOOLS=ON" coastal intel NO NO

Expected behavior
Having executable with PIO support.

Screenshots

ld: ../../../lib/libww3.a(wav_history_mod.F90.o): in function `wav_history_mod_mp_write_history_':
/work2/noaa/nems/tufuk/COASTAL/ufs-coastal-app-test/sorc/ufs-weather-model/WW3/model/src/wav_history_mod.F90:136: undefined reference to `piolib_mod_mp_createfile_'
ld: /work2/noaa/nems/tufuk/COASTAL/ufs-coastal-app-test/sorc/ufs-weather-model/WW3/model/src/wav_history_mod.F90:161: undefined reference to `pio_nf_mp_def_dim_int_desc_'
ld: /work2/noaa/nems/tufuk/COASTAL/ufs-coastal-app-test/sorc/ufs-weather-model/WW3/model/src/wav_history_mod.F90:162: undefined reference to `pio_nf_mp_def_dim_int_desc_'
ld: /work2/noaa/nems/tufuk/COASTAL/ufs-coastal-app-test/sorc/ufs-weather-model/WW3/model/src/wav_history_mod.F90:163: undefined reference to `pio_nf_mp_def_dim_int_desc_'
ld: /work2/noaa/nems/tufuk/COASTAL/ufs-coastal-app-test/sorc/ufs-weather-model/WW3/model/src/wav_history_mod.F90:175: undefined reference to `pio_nf_mp_def_var_md_desc_'

Additional context
Possible fix:

--- a/model/src/CMakeLists.txt
+++ b/model/src/CMakeLists.txt
@@ -178,6 +178,7 @@ endif()
 
 if("PIO" IN_LIST switches)
   target_sources(ww3_lib PRIVATE ${pio_src})
+  target_link_libraries(ww3_lib PUBLIC PIO::PIO_Fortran)
 endif()

[JessicaMeixner-NOAA]

You probably need to remove the PIO when building shared utilities.

[uturuncoglu]

@JessicaMeixner-NOAA but the code gives error in wav_history_mod.F90 not in shared utils.

[JessicaMeixner-NOAA]

Which libraries do you expect to be compiled with PIO? You should only have this for the coupled exe only. It's otherwise not supported.

[uturuncoglu]

@JessicaMeixner-NOAA It is not a library. I am trying to create UFS executable too for a configuration with WW3. The build failing with the way that I mentioned in the description.

[JessicaMeixner-NOAA]

Does it work if you do BUILD_TOOLS=OFF?

[JessicaMeixner-NOAA]

Or does it work with your possible fix you mentioned?

[uturuncoglu]

@JessicaMeixner-NOAA Yes, the fix is working in our end and compiles without any issue.