Revert "Kempe standoff"

Author: martin-springer

.github/workflows/publish-to-test-pypi.yml

@@ -2,7 +2,7 @@
 # See https://pre-commit.com/hooks.html for more hooks
 repos:
 -   repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.5.0
+    rev: v3.2.0
     hooks:
     -   id: trailing-whitespace
     -   id: end-of-file-fixer

.pre-commit-config.yaml

@@ -107,7 +107,6 @@ def solder_fatigue(
     b=0.33,
     C1=405.6,
     Q=0.12,
-    wind_factor=None,
 ):
     """
     Get the Thermomechanical Fatigue of flat plate photovoltaic module solder joints.
@@ -128,13 +127,6 @@ def solder_fatigue(
         Must contain dni, dhi, ghi, temp_air, windspeed, and datetime index
     meta : dict
         site location meta-data
-    wind_factor : float, optional
-        Wind speed correction exponent to account for different wind speed measurement heights
-        between weather database (e.g. NSRDB) and the tempeature model (e.g. SAPM)
-        The NSRDB provides calculations at 2 m (i.e module height) but SAPM uses a 10 m height.
-        It is recommended that a power-law relationship between height and wind speed of 0.33
-        be used. This results in a wind speed that is 1.7 times higher. It is acknowledged that
-        this can vary significantly.
     time_range : timestamp series, optional
         Local time of specific site by the hour year-month-day hr:min:sec
         (Example) 2002-01-01 01:00:00
@@ -177,9 +169,7 @@ def solder_fatigue(
         time_range = weather_df.index
 
     if temp_cell is None:
-        temp_cell = temperature.cell(
-            weather_df=weather_df, meta=meta, wind_factor=wind_factor
-        )
+        temp_cell = temperature.cell(weather_df, meta)
 
     temp_amplitude, temp_max_avg = _avg_daily_temp_change(time_range, temp_cell)
 

pvdeg/data/psm3.csv

@@ -657,13 +657,13 @@ def module(
     azimuth=180,
     sky_model="isotropic",
     temp_model="sapm",
-    conf="open_rack_glass_glass",
+    mount_type="open_rack_glass_glass",
     WVTRo=7970633554,
     EaWVTR=55.0255,
     So=1.81390702,
     l=0.5,
     Eas=16.729,
-    wind_factor=0.33,
+    wind_speed_factor=1,
 ):
     """Calculate the Relative Humidity of solar module backsheet from timeseries data.
 
@@ -702,13 +702,9 @@ def module(
     Eas : float
         Encapsulant solubility activation energy in [kJ/mol]
         Eas = 16.729(kJ/mol) is the suggested value for EVA.
-    wind_factor : float, optional
-        Wind speed correction exponent to account for different wind speed measurement heights
+    wind_speed_factor : float, optional
+        Wind speed correction factor to account for different wind speed measurement heights
         between weather database (e.g. NSRDB) and the tempeature model (e.g. SAPM)
-        The NSRDB provides calculations at 2 m (i.e module height) but SAPM uses a 10 m height.
-        It is recommended that a power-law relationship between height and wind speed of 0.33
-        be used. This results in a wind speed that is 1.7 times higher. It is acknowledged that
-        this can vary significantly.
 
     Returns
     --------
@@ -718,7 +714,7 @@ def module(
 
     # solar_position = spectral.solar_position(weather_df, meta)
     # poa = spectral.poa_irradiance(weather_df, meta, solar_position, tilt, azimuth, sky_model)
-    # temp_module = temperature.module(weather_df, poa, temp_model, mount_type, wind_factor)
+    # temp_module = temperature.module(weather_df, poa, temp_model, mount_type, wind_speed_factor)
 
     poa = spectral.poa_irradiance(
         weather_df=weather_df,
@@ -733,8 +729,8 @@ def module(
         meta,
         poa=poa,
         temp_model=temp_model,
-        conf=conf,
-        wind_factor=wind_factor,
+        conf=mount_type,
+        wind_speed_factor=wind_speed_factor,
     )
 
     rh_surface_outside = surface_outside(
@@ -794,7 +790,7 @@ def module(
 #     So=1.81390702,
 #     l=0.5,
 #     Eas=16.729,
-#     wind_factor=1
+#     wind_speed_factor=1
 # ):
 
 #     """Run the relative humidity calculation for a set of project points."""
@@ -865,7 +861,7 @@ def module(
 #                 So,
 #                 l,
 #                 Eas,
-#                 wind_factor
+#                 wind_speed_factor
 #             )
 #             future_to_point[future] = gid
 

pvdeg/data/xeff_demo.csv

@@ -42,7 +42,7 @@ def solar_position(weather_df, meta):
 
 
 def poa_irradiance(
-    weather_df, meta, sol_position=None, tilt=None, azimuth=None, sky_model="isotropic"
+    weather_df, meta, sol_position=None, tilt=None, azimuth=180, sky_model="isotropic"
 ):
     """
     Calculate plane-of-array (POA) irradiance using pvlib based on weather data from the
@@ -60,7 +60,7 @@ def poa_irradiance(
         The tilt angle of the PV panels in degrees, if None, the latitude of the
         location is used.
     azimuth : float, optional
-        The azimuth angle of the PV panels in degrees. Equatorial facing by default.
+        The azimuth angle of the PV panels in degrees, 180 by default - facing south.
     sky_model : str, optional
         The pvlib sky model to use, 'isotropic' by default.
 
@@ -74,11 +74,6 @@ def poa_irradiance(
     # TODO: change for handling HSAT tracking passed or requested
     if tilt is None:
         tilt = float(meta["latitude"])
-    if azimuth is None:  # Sets the default orientation to equator facing.
-        if float(meta["latitude"]) < 0:
-            azimuth = 0
-        else:
-            azimuth = 180
 
     if sol_position is None:
         sol_position = solar_position(weather_df, meta)