Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sparse factory method tests #871

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Add sparse factory method tests #871

merged 3 commits into from
Feb 7, 2025

Conversation

aartbik
Copy link
Contributor

@aartbik aartbik commented Feb 6, 2025

No description provided.

cliffburdick
cliffburdick reviewed Feb 6, 2025
View reviewed changes
test/CMakeLists.txt Outdated Show resolved Hide resolved
cliffburdick
cliffburdick reviewed Feb 6, 2025
View reviewed changes
test/sparse/Sparse.cu Outdated Show resolved Hide resolved
cliffburdick
cliffburdick reviewed Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@cliffburdick cliffburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Sparse.cu" is too generic of a name if this is going in its own folder. If it's just going to be one large file it can go in 00_tensor with that name. If you plan on having a lot of separate tests, This might be "Basic.cu" or something.

@aartbik aartbik requested a review from cliffburdick February 6, 2025 22:01
@aartbik
Copy link
Contributor Author

aartbik commented Feb 6, 2025

I think "Sparse.cu" is too generic of a name if this is going in its own folder. If it's just going to be one large file it can go in 00_tensor with that name. If you plan on having a lot of separate tests, This might be "Basic.cu" or something.

Renamed.

@cliffburdick
Copy link
Collaborator

/build

@cliffburdick cliffburdick merged commit 252dc03 into NVIDIA:main Feb 7, 2025
1 check passed
@cliffburdick cliffburdick deleted the buk branch February 7, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffburdick cliffburdick cliffburdick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aartbik @cliffburdick