Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Debug unaligned MXFP8 dequantize tests #1450

Conversation

timmoon10
Copy link
Collaborator

Description

#1437 introduced some MXFP8 dequantization test failures because some cases have invalid alignment for TMA.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Skip MXFP8 dequantize tests with invalid alignment

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added bug Something isn't working testing Improvements to tests or testing infrastructure 2.0.0 labels Feb 1, 2025
@timmoon10
Copy link
Collaborator Author

Pipeline 23333837

Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 merged commit f694199 into NVIDIA:release_v2.0 Feb 1, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 bug Something isn't working testing Improvements to tests or testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant