[PyTorch] Fix backward compatibility with checkpoint API #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
|
/te-ci pytorch |
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
ksivaman
force-pushed
the
backward_compatible_activation_recompute
branch
from
4455c0a to
4e1270c
Compare
|
/te-ci pytorch |
ksivaman
added a commit
that referenced
this pull request
Apr 3, 2024
* Fix backward compatibility with checkpoint API Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> * review comments and fix lint Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> --------- Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
pggPL
pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 15, 2024
* Fix backward compatibility with checkpoint API Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> * review comments and fix lint Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> --------- Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the new API backward compatible with previous version. In addition, the
requires_gradfield is checked by PyTorch during the backward call. Checking this in the forward requires user intervention as they need to call vanilla forward during eval steps.