Fix undefined symbol issue for transformer_engine::getenv #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinze Xue <jinzex@nvidia.com>
|
/te-ci pytorch |
|
This hack works around the immediate issue, but I think it may be worth doing a proper refactor to avoid ABI issues in the future. See #756 (comment). |
timmoon10
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
We'll merge this before the 1.6 release to quickly unblock users. Long-term, the build system should have logic to ensure ABI compatibility with PyTorch (see #756 (comment)).
13 tasks
pggPL
pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 9, 2024
Signed-off-by: Jinze Xue <jinzex@nvidia.com> Co-authored-by: Jinze Xue <jinzex@nvidia.com>
pggPL
pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 15, 2024
Signed-off-by: Jinze Xue <jinzex@nvidia.com> Co-authored-by: Jinze Xue <jinzex@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
pggPL
pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 23, 2024
Signed-off-by: Jinze Xue <jinzex@nvidia.com> Co-authored-by: Jinze Xue <jinzex@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #756. The issue happens because we recently included
common/util/system.hinto PyTorch source CPP files at https://github.com/NVIDIA/TransformerEngine/pull/713/files to utilize thetransformer_engine::getenvmethod. As a result, the PyTorchtransformer_engine_extensionswill now search for symbols within thelibtransformer_engine.solibrary.However, if the user builds TransformerEngine in a local environment (conda or PyPI), because the pre-built PyTorch, either from conda or PyPI, has the CXX11_ABI set as False, whereas the common library is using the new CXX11_ABI. As a result, there will be an undefined symbol problem when importing
transformer_engine_extensions. NGC PyTorch container is usingCXX11_ABI=1, so there is no problem.