Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scale menu] Dropdown menu short enough to keep xylophone visible #104

Open
ceciliabjork opened this issue Sep 20, 2021 · 5 comments
Open

Comments

@ceciliabjork
Copy link

ceciliabjork commented Sep 20, 2021

@saxjax @MartinBruun After discussion with @granfors:
We thoroughly enjoy the new scales that are added to the scale menu, but the menu is now so long when dropped down that it covers the xylophone and the note names. One main point of the app is to be able to quickly get a visual sense of how scales are similar and different without having to close and reopen the scale menu in between: for example, to click back and forth between major and Mixolydian, and between different minor scales, to see the "movement" when tones and semitones change places.
We suggest the following to save space:

  1. remove all scales after major blues
  2. move Customize to the end of the list and use the same smaller font as for the scales. Maybe an arrow ◀️ to the left of the word Customize, to signal that an additional menu will become visible?
    As it is now, the user could imagine that "Customize" is the heading for the entire menu, so this would solve that as well.
@saxjax
Copy link
Collaborator

saxjax commented Sep 21, 2021

Got it, thats a really good point!
I'm om it

@ceciliabjork
Copy link
Author

Got it, thats a really good point!
I'm om it

Brilliant, thank you! :)

@saxjax
Copy link
Collaborator

saxjax commented Sep 21, 2021

done, except for the little arrow, I will be on that later.
https://deploy-preview-106--notio-novia-fi.netlify.app/
please check the preview, then I will add it to master if you approve it.
best Jakob

@ceciliabjork
Copy link
Author

done, except for the little arrow, I will be on that later.
https://deploy-preview-106--notio-novia-fi.netlify.app/
please check the preview, then I will add it to master if you approve it.
best Jakob
@saxjax @granfors Super!! This already helped and it works splendidly as far as I can see. I think we can find ways of saving even more space later but this solves the visibility issue for now. 👍

@saxjax saxjax closed this as completed Oct 10, 2021
@saxjax
Copy link
Collaborator

saxjax commented Oct 10, 2021

I added this to our sprint backlog:
Maybe an arrow ◀️ to the left of the word Customize, to signal that an additional menu will become visible?

@saxjax saxjax reopened this Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants