Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues while reading or writing mdl files #2

Open
Otaka opened this issue Jan 21, 2023 · 1 comment
Open

Issues while reading or writing mdl files #2

Otaka opened this issue Jan 21, 2023 · 1 comment
Labels
bug Something isn't working effort/weeks help wanted Extra attention is needed need/team-effort-estimate need/triage popularity-high

Comments

@Otaka
Copy link

Otaka commented Jan 21, 2023

I am trying to batch convert KOTOR models to ASCII format. I executed pip install pykotor and wrote the following application(reduced)

from pykotor.resource.formats.mdl import read_mdl, write_mdl
from pykotor.resource.type import ResourceType
model = read_mdl(original_files_folder + file_name)
write_mdl(model, converted_files_folder + converted_file_name, ResourceType.MDL_ASCII)

but unfortunatelly around 30% of files from models.bif archite are failed with some errors.
For example:

write_mdl list index out of range
Files: dor_lhr02.mdl, dor_lma01.mdl, c_drdwar.mdl, c_drdastro.mdl ...

read_mdl 501 is not a valid SurfaceMaterial
Files: c_dewback.mdl,lqa_dewback.mdl, m01aa_c01_char02.mdl, m08aa_05a.mdl ...

read_mdl 38 is not a valid SurfaceMaterial
Files: m12aa_c03_char02.mdl, m12aa_c04_char01.mdl ...

read_mdl 8195 is not a valid SurfaceMaterial
Files: m02aa_09b.mdl...

read_mdl unpack requires a buffer of 4 bytes
Files: m12aa_c04_cam.mdl, m12ab_mgt02.mdl, m12ab_mgt05.mdl
@NickHugi
Copy link
Owner

NickHugi commented Feb 7, 2023

Reading/Writing MDLs is not yet fully supported. Its been a while since I looked at the code but I believe certain node types (walkmesh, skinmesh, saber, and probably some others) are not accounted for when reading leading to some unpredictable errors.

I do plan on revisting the MDL modules sometime soon but there are a few other things that I am prioritising as of this moment.

th3w1zard1 added a commit that referenced this issue Feb 27, 2024
@th3w1zard1 @actions-user
Automatic Deployment, Tests, Reports, Badges and more. (#46)
d18d3b6 
* merge all workflows into a matrix strategy

create status badges from the results.

* test a github action problem

* #2 test github action problem

* fix missing python version

* quote the python versions - otherwise treated as floats

* don't fast-fail the others when a single matrix build fails.

* possibly fix the concurrency issue

* increase verbosity to find the problem

* test #5billion

* Update compile_and_test_pykotor.yml

* workaround fix maybe?

* configure the fast-fail stuff

* Separate test workflow from compile workflow.

* fix commit permissions

* Update README with custom test status badge for tests-ubuntu-3.11

* merge the workflows, otherwise we run out of runners

also fix the pytest xml parsing.

* Revert "Update README with custom test status badge for tests-ubuntu-3.11"

This reverts commit ccafebd.

* Update README with custom test status badges for ubuntu-3.8

* next test

This reverts commit ca903f4.

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* cleanup deps, fix download-artifact

* Update README with custom test status badges

* fix the badge icon, ensure LD_LIBRARY_PATH is defined

* qol

- add warnings when upgrading centos to alma
- cleanup 'find-python' to reduce duplicated blocks
- support python 3.13/3.14

* debug the issue

* fix the check

* fix toolset deps broken in recent commit

* increase granularity of python versions/operating system combinations

* add workaround when activate.ps1 venv script isn't found.

* Update install_python_venv.ps1

* correct the Pillow version requirement

* Update publish_and_test_pykotor.yml

* potentially fix rare venv problems

* bump minimum required macos version to 12

* fix conflicts/race condition with readme updates

* general fixes/cleanup

- always run the update-readme task regardless of whether build completed or not
- add extra fallbacks to powershell installer bash script
- fix issue with python 3.13's alpha version failing to install numpy (needs upgraded meson I guess)

* Update README with custom test status badges

* add x86 vs x64

* don't attempt x86 python runners, upgrade meson when v3.13 python used

* fix py313 and debug xml parsing problem

* Update publish_and_test_pykotor.yml

* Update README with custom test status badges

* fixes

* Update README with custom test status badges

* exclude most runners until the issue is fixed

* Update README with custom test status badges

* commit test results to repo, hyperlink badges to the results.

* Update README with custom test status badges

* Upload test results

* Update README with custom test status badges

* Upload test results

* Update README with custom test status badges

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* Upload test results

* add other matrix runners

* Upload test results

* Update README with custom test status badges

* support upx, fix readme badge again.

* syntax error

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update README with custom test status badges

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update README with custom test status badges

* test a strategy

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Update test_badge.ps1

* Update publish_and_test_pykotor.yml

* Add test results

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* cancel unfinished workflows with the same ref

* Update publish_and_test_pykotor.yml

* Add test results

* Update publish_and_test_pykotor.yml

* figure out where mac is building this thing

* Update publish_and_test_pykotor.yml

* Add test results

* Update publish_and_test_pykotor.yml

* Add test results

* replace deprecated features, fix test parsing

* Add test results

* fix upx

* link to failed builds

* fix env

* possibly fix upx-dir?

* Add test results

* Update publish_and_test_pykotor.yml

* Add test results

* Update publish_and_test_pykotor.yml

* Update publish_and_test_pykotor.yml

* Add test results

* pyinstaller for windows requires visual studio 2015 redists apparently.

* fix test results path

* fix github repo urls

* fix some easy issues with python 3.7/3.13

* Add test results

* remaining fixes.

* Add test results

* Update publish_and_test_pykotor.yml

* Add test results

* Add test results

* cleanup output

* test badge organizations

* Add test results

* Add test results

* second organization test

* move the badges to the bottom of the readme.

* fixes/reversions

* shorten the labels

* yet more fixes

* fix archive names upx

* Update publish_and_test_pykotor.yml

* Add test results

* Add test results

* fixes

* Update publish_and_test_pykotor.yml

* Add test results

* Add test results

* fix minimum required setuptools version

* Update publish_and_test_pykotor.yml

* Add test results

* Add test results

---------

Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working effort/weeks help wanted Extra attention is needed need/team-effort-estimate need/triage popularity-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Otaka @th3w1zard1 @NickHugi