Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent closing of bottom panel in Image Viewer #14

Open
LilyStilson opened this issue Jun 27, 2023 · 0 comments
Open

Fix inconsistent closing of bottom panel in Image Viewer #14

LilyStilson opened this issue Jun 27, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@LilyStilson
Copy link
Contributor

The problem

Currently, if bottom pane contents in ImageViewerPage can scroll, then SingleChildScrollView overrides scrolling behavior of the Pane and there is no way to close it, unless you grab the header, which is not the part of a scroll view mentioned above.

Expected behavior

Panel closes regardless of its contents when user swipes down on it.

Device information

All platforms

Additional context

Looks like we'd need to wait for the SlidingUpPanel to be updated or find our own solution, because using provided ScrollController does fix the issue, but messes up pagination...

@LilyStilson LilyStilson added bug Something isn't working needs triage Waits for developer to check and confirm the issue labels Jun 27, 2023
LilyStilson added a commit to LilyStilson/ibuki-mobile that referenced this issue Jun 27, 2023
Test implementation for Pane hiding (Night-Sky-Studio#14)
@LilyStilson LilyStilson removed the needs triage Waits for developer to check and confirm the issue label Jun 27, 2023
@LilyStilson LilyStilson self-assigned this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant