Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore peer dependencies #8

Open
KurtGokhan opened this issue Jun 24, 2024 · 3 comments
Open

Ignore peer dependencies #8

KurtGokhan opened this issue Jun 24, 2024 · 3 comments

Comments

@KurtGokhan
Copy link

Thanks for the tool. Very helpful.

The tool seems to also include peer dependencies. As peer dependencies aren't installed, I think they should be excluded from the analysis.

@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Jun 24, 2024

Peer dependencies must be installed for a package to work tho, so it makes sense to include them in the analysis

This is important for folks with auto-install-peers environments, where their parkage.jsons do not tell the whole truth

@KurtGokhan
Copy link
Author

Peer dependencies can be optional tho.

Maybe there can be a CLI option to ignore them?

@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Jun 24, 2024

I think we could safely always ignore optional peers, tbh -- would accept a PR for this.

reasoning being, if you're using optional peers, auto-install-peers behavior would require you to declare the optional peer in your package.json, in which case, this tool would pull in the data from that package.json.

seems safe 🎉 good thinkin'!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants