-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements for the gesture interface #5
Comments
Gesture interface is now up and running No need to wait :) |
Hi @yboger, I was looking for a "GestureInterface" class in the PluginKit (https://github.com/OSVR/OSVR-Core/tree/master/inc/osvr/PluginKit), but I didn't see one. What is the expected way for the plugin to send gesture events/information? |
@zachkinstner my mistake. The code is ready and it is being checked in this morning. Stay tuned. |
You might want to take a look (and comment, if you wish) on this pull request OSVR/OSVR-Core#181 which includes the gestures |
@zachkinstner , you can checkout gesture branch before it's merged into master and build it. It would have the code that you are looking for. This would also be a good way to review the pull request and comment on it. |
A review/summary from the plugin perspective... The C interface: osvrDeviceGestureConfigure()
osvrDeviceGestureReportData()
The C++ device interface: sendGestureData()
Preset gesture strings: #define OSVR_GESTURE_SWIPE_LEFT "SwipeLeft"
#define OSVR_GESTURE_SWIPE_RIGHT "SwipeRight"
#define OSVR_GESTURE_SCROLL_UP "ScrollUp"
#define OSVR_GESTURE_SCROLL_DOWN "ScrollDown"
#define OSVR_GESTURE_SINGLE_TAP "SingleTap"
#define OSVR_GESTURE_DOUBLE_TAP "DoubleTap"
#define OSVR_GESTURE_PINCH "Pinch"
#define OSVR_GESTURE_FINGER_SPREAD "FingerSpread"
#define OSVR_GESTURE_CIRCLE "Circle"
#define OSVR_GESTURE_LONG_PRESS "LongPress"
#define OSVR_GESTURE_OPEN_HAND "OpenHand"
#define OSVR_GESTURE_CLOSED_HAND "ClosedHand" So usage might look like this: mGestureDevice.sendGestureData(OSVR_GESTURE_IN_PROCESS, OSVR_GESTURE_CIRCLE, 0, &time) Should there be a way to provide numeric data about the gesture?
|
The commit referenced above includes a new Regarding the numeric data that I mentioned in my previous comment, I'll summarize the data that seems most important for the Leap Motion gestures. All Leap Motion gestures have:
The other information can be factored into five values:
|
@zachkinstner the gesture data table is exactly right. And, without this data it seems very odd to provide gestures at all. |
Agreed. The position and direction information, in particular, seems vital to provide. Looking at the table, we could potentially combine direction and speed into one "velocity" value.
I created new milestone tags, and gave this issue the "Later Release" milestone. |
Refer to the gesture Interface Class Description and Summary documents. These seem to be in the discussion phase -- I don't think there is an API available for gestures yet.
Some notes from the docs:
For our initial work, the gesture interface has a lower priority than the imaging, tracker, and config-related interfaces. Let's use this ticket to discuss details and decide how/when to proceed with gestures.
The text was updated successfully, but these errors were encountered: