Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor thumbnails #25

Open
OfficiallyM opened this issue Oct 20, 2023 · 4 comments
Open

Refactor thumbnails #25

OfficiallyM opened this issue Oct 20, 2023 · 4 comments
Labels
core This is a change to the mod core enhancement New feature or request
Milestone

Comments

@OfficiallyM
Copy link
Owner

Thumbnail generation is slow and there's been one known case of it crashing the game (suspect it took too long and Unity killed the process)

Multithread the generation to improve performance

@OfficiallyM OfficiallyM added the enhancement New feature or request label Oct 20, 2023
@OfficiallyM OfficiallyM added this to the v2.5.0 milestone Nov 10, 2023
@OfficiallyM OfficiallyM removed this from the v2.5.0 milestone Nov 19, 2023
@OfficiallyM
Copy link
Owner Author

Requires more thought.

Queue all needed thumbnails, multithreaded generate in chunks, provide all thumbnails to UI?

Currently, thumbnail is loaded when looping all items so needs to either be available at that point or be added to the items list post generation

@OfficiallyM
Copy link
Owner Author

Attempt to find which items don't have thumbnails and create those, no point regenerating all the thumbnails every time. Just add a way of clearing the thumbnail cache manually from the UI.

Could still be worth generating the thumbnails multithreaded in chunks to improve initial load performance

@OfficiallyM OfficiallyM added this to the v3.0.0 milestone Apr 8, 2024
@OfficiallyM
Copy link
Owner Author

Changed to only create missing in 3bf9d62
Also added a button in misc to force refresh the cache

@OfficiallyM
Copy link
Owner Author

Delaying rest until next version

@OfficiallyM OfficiallyM modified the milestones: v3.0.0, v3.1.0 Apr 29, 2024
@OfficiallyM OfficiallyM added the core This is a change to the mod core label Jul 31, 2024
@OfficiallyM OfficiallyM modified the milestones: v3.1.0, v3.2.0 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This is a change to the mod core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant