Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin triggers a "please reload" dialog after every job #200

Open
dimo414 opened this issue Aug 2, 2022 · 7 comments
Open

Plugin triggers a "please reload" dialog after every job #200

dimo414 opened this issue Aug 2, 2022 · 7 comments

Comments

@dimo414
Copy link

dimo414 commented Aug 2, 2022

I've been noticing for a while now that if I leave OctoPrint open for too long it ends up displaying a "Please Reload" overlay dialog even though nothing should have changed with the server. A few searches found similar reports like OctoPrint/OctoPrint#2950 which suggest the issue is plugins writing to the OctoPrint config unnecessarily. After snapshotting my config for a little while I hit another dialog today and this plugin appears to be a culprit:

$ diff -u /tmp/octoprint-config-2022-07-31_05.53.57.yaml /tmp/octoprint-config-2022-08-02_05.59.26.yaml
--- /tmp/octoprint-config-2022-07-31_05.53.57.yaml      2022-07-31 05:53:57.356692508 +0000
+++ /tmp/octoprint-config-2022-08-02_05.59.26.yaml      2022-08-02 05:59:26.685099734 +0000
@@ -34,7 +34,7 @@
     pluginCheckActivated: false
     preferedImageSource: camera
     selectedFilamentTrackerPlugin: SpoolManager Plugin
-    showPrintJobDialogAfterPrint_jobId: 251
+    showPrintJobDialogAfterPrint_jobId: 253
   SlicerEstimator:
     _config_version: 2
     pdp: '1'

I'm guessing this job ID value should be stored somewhere other than the OctoPrint config, since updating it seems to trigger this "please reload" overlay unnecessarily.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@github-actions github-actions bot added the status: markedForAutoClose Issue will be closed automatically label Sep 2, 2022
@dimo414
Copy link
Author

dimo414 commented Sep 2, 2022

AFAIK this is still an issue.

@github-actions github-actions bot removed the status: markedForAutoClose Issue will be closed automatically label Sep 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@github-actions github-actions bot added the status: markedForAutoClose Issue will be closed automatically label Oct 4, 2022
@dimo414
Copy link
Author

dimo414 commented Oct 4, 2022

AFAIK this is still an issue.

@github-actions github-actions bot removed the status: markedForAutoClose Issue will be closed automatically label Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@github-actions github-actions bot added the status: markedForAutoClose Issue will be closed automatically label Nov 4, 2022
@dimo414
Copy link
Author

dimo414 commented Nov 4, 2022

@OllisGit I don't mind this bug sitting idle, I'm sure you have better things to do, but could you turn off the auto-closer? I don't know what else to do than ping this every month which is just obnoxious for everyone involved.

@github-actions github-actions bot removed the status: markedForAutoClose Issue will be closed automatically label Nov 5, 2022
@david-dasilva
Copy link

Please store the current job id elsewhere to prevent this reloading.
I'm not familiar with Octoprint plugins but I will try to take a look when I find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants