Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job manager: rename "start_job" to "create_job" #724

Open
soxofaan opened this issue Feb 7, 2025 · 2 comments
Open

job manager: rename "start_job" to "create_job" #724

soxofaan opened this issue Feb 7, 2025 · 2 comments

Comments

@soxofaan
Copy link
Member

soxofaan commented Feb 7, 2025

The job manager API has this "start_job" callable:

:param start_job:
A callback which will be invoked with, amongst others,
the row of the dataframe for which a job should be created and/or started.
This callable should return a :py:class:`openeo.rest.job.BatchJob` object.

This callable allows the user to just create a job, or also start it.
The current name encourages the user to start it,
but I think we should actually recommend against that because that undermines the possibilities to handle the job starting in a smarter way (e.g. do the "start job" request in a worker thread for more efficient time management)

@soxofaan
Copy link
Member Author

soxofaan commented Feb 7, 2025

e.g. this is a stumbling block for #719

@soxofaan
Copy link
Member Author

soxofaan commented Feb 7, 2025

cc @HansVRP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant