-
Notifications
You must be signed in to change notification settings - Fork 285
(ETH) The order state for the buyer fails to transition to RESOLVED in disputes #2005
Comments
At first we believed that the order state wasn't transitioning because the transaction to release the funds from escrow hadn't confirmed, but that's clearly not true. Here is the transaction releasing the funds from escrow: |
On further analysis, the problem we're having is a failure in calling the execute() function in the smart contract to release the funds. @jjeffryes reported something similar for his case (#2002), and I’ve just confirmed it in the tests that I thought were passing. The tx data from Etherscan:
The moderator payout here was 0%. The difference matches exactly with what @jjeffryes reported: #2002 (comment) |
My shot in the dark uneducated guess is that we’re substracting the expected transaction fee from the total we’re trying to release because that’s what we do in Bitcoin, but for ETH it doesn’t work that way… you have to have gas in your wallet to transfer and release funds, the gas doesn't come out of the value locked in escrow... I'd start by checking there. |
One thing that is confusing here is sometimes this bug doesn't happen. If the issue is the gas is being subtracted from the total, wouldn't the bug happen every time? Or could there be some math issue where sometimes the value is off enough the gas can be subtracted and everything still works? |
No it happens every time for me. |
So running the ETH qa tests, which are similar, seems to be producing the correct result. That is, it's correctly sending the funds out and setting the state on both nodes as RESOLVED. I do notice that in your test case above the vendor files the dispute and the buyer closes it (which is unusually unless it was a split payout). Is it possible this could be causing the issue? |
It's happening when the buyer or seller opens the dispute. |
Fixed |
These are the steps to replicate the issue:
This is the order JSON from the
seller
:This is the order JSON from the
buyer
:The text was updated successfully, but these errors were encountered: