Enforce single owner per project

OpenGeoscience · Oct 1, 2024 · 448d070 · 448d070
1 parent 305f0b2
commit 448d070
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/uvdat/core/models/project.py b/uvdat/core/models/project.py
@@ -16,7 +16,7 @@ class Project(models.Model):
     @transaction.atomic()
     def set_permissions(
         self,
-        owner: list[User] | None = None,
+        owner: User,
         collaborator: list[User] | None = None,
         follower: list[User] | None = None,
     ):
@@ -28,8 +28,7 @@ def set_permissions(
         ).delete()
 
         # Assign new perms
-        for user in owner or []:
-            assign_perm('owner', user, self)
+        assign_perm('owner', owner, self)
         for user in collaborator or []:
             assign_perm('collaborator', user, self)
         for user in follower or []:

diff --git a/uvdat/core/rest/serializers.py b/uvdat/core/rest/serializers.py
@@ -40,10 +40,11 @@ def get_center(self, obj):
             return [obj.default_map_center.y, obj.default_map_center.x]
 
     def get_owner(self, obj):
-        users = get_users_with_perms(obj, only_with_perms_in=['owner'])
-        if users.count() == 0:
-            return None
-        return UserSerializer(users.first()).data
+        users = list(get_users_with_perms(obj, only_with_perms_in=['owner']))
+        if len(users) != 1:
+            raise Exception('Project must have exactly one owner')
+
+        return UserSerializer(users[0]).data
 
     def get_collaborators(self, obj):
         users = get_users_with_perms(obj, only_with_perms_in=['collaborator'])