From bb009467826b3e73dafe47971975c96748b58bbb Mon Sep 17 00:00:00 2001
From: Anne Haley <anne.haley@kitware.com>
Date: Tue, 25 Feb 2025 18:48:03 +0000
Subject: [PATCH] feat: Allow docking floating panels in either sidebar in any
 order

---
 web/src/components/FloatingPanel.vue | 15 ++++--
 web/src/components/SideBars.vue      | 32 +++++------
 web/src/drag.ts                      | 81 +++++++++++++++-------------
 web/src/storeFunctions.ts            | 16 ++++--
 web/src/types.ts                     |  4 +-
 5 files changed, 84 insertions(+), 64 deletions(-)

diff --git a/web/src/components/FloatingPanel.vue b/web/src/components/FloatingPanel.vue
index d5b1bf4f..8549d5f9 100644
--- a/web/src/components/FloatingPanel.vue
+++ b/web/src/components/FloatingPanel.vue
@@ -1,7 +1,12 @@
 <script setup lang="ts">
 import { computed, ref } from "vue";
 
-import { panelArrangement } from "@/store";
+import ChartsPanel from "./ChartsPanel.vue";
+import AnalyticsPanel from "./AnalyticsPanel.vue";
+import DatasetsPanel from "./DatasetsPanel.vue";
+import LayersPanel from "./LayersPanel.vue";
+
+import { panelArrangement, availableDatasets } from "@/store";
 import { startDrag } from "@/drag";
 
 const props = defineProps<{
@@ -24,6 +29,7 @@ function getPanelContainerClass() {
 
 function getPanelContainerStyle() {
   let styleObj: Record<string, string> = {};
+  styleObj.order = panel.value?.order.toString() || '0';
   if (!panel.value?.position) {
     if (panel.value?.height && !panel.value.collapsed) {
       styleObj.height = panel.value?.height + "px";
@@ -36,7 +42,7 @@ function getPanelContainerStyle() {
 function getPanelStyle() {
   let styleObj: Record<string, string> = {};
   if (panel.value?.position) {
-    styleObj["z-index"] = "10000"; // above vuetify navigation drawer
+    styleObj["z-index"] = "2"; // above vuetify navigation drawer
     styleObj.visibility = "visible"; // prevent hiding when sidebar closes
     styleObj.position = "absolute";
     styleObj.top = panel.value.position.y + "px";
@@ -113,7 +119,10 @@ function panelUpdated() {
         </div>
         <v-card-text class="pa-2">{{ panel.label }}</v-card-text>
         <v-card-text v-if="!panel.collapsed" class="pa-2 panel-content">
-          <slot></slot>
+          <DatasetsPanel v-if="props.id === 'datasets'" :datasets="availableDatasets"/>
+          <LayersPanel v-else-if="props.id === 'layers'"/>
+          <ChartsPanel v-else-if="props.id === 'charts'"/>
+          <AnalyticsPanel v-else-if="props.id === 'analytics'"/>
           <v-icon
             v-if="panel.position"
             icon="mdi-resize-bottom-right"
diff --git a/web/src/components/SideBars.vue b/web/src/components/SideBars.vue
index df3d4d74..4ceb1959 100644
--- a/web/src/components/SideBars.vue
+++ b/web/src/components/SideBars.vue
@@ -2,16 +2,11 @@
 import { ref, Ref, watch } from "vue";
 import { useTheme } from "vuetify/lib/framework.mjs";
 
-import { availableDatasets, currentUser, openSidebars, panelArrangement, theme } from "@/store";
+import { currentUser, openSidebars, panelArrangement, theme } from "@/store";
 import { logout } from "@/api/auth";
-import { FloatingPanelConfig } from "@/types";
 
 import FloatingPanel from "./FloatingPanel.vue";
 import ProjectConfig from "./ProjectConfig.vue";
-import ChartsPanel from "./ChartsPanel.vue";
-import AnalyticsPanel from "./AnalyticsPanel.vue";
-import DatasetsPanel from "./DatasetsPanel.vue";
-import LayersPanel from "./LayersPanel.vue";
 
 const version = process.env.VUE_APP_VERSION;
 const hash = process.env.VUE_APP_HASH;
@@ -106,12 +101,11 @@ watch(darkMode, () => {
       </v-toolbar>
       <ProjectConfig />
       <div class="panel-set">
-        <FloatingPanel id="datasets">
-          <DatasetsPanel :datasets="availableDatasets"/>
-        </FloatingPanel>
-        <FloatingPanel id="layers" bottom>
-          <LayersPanel />
-        </FloatingPanel>
+        <FloatingPanel
+          v-for="panel, index in panelArrangement.filter((p) => p.dock == 'left')"
+          :id="panel.id"
+          :bottom="index ==  panelArrangement.filter((p) => p.dock == 'right').length -1"
+        />
       </div>
     </v-navigation-drawer>
 
@@ -191,7 +185,7 @@ watch(darkMode, () => {
             ></v-icon>
           </template>
           <v-list
-            :items="panelArrangement.filter((p) => p.right)"
+            :items="panelArrangement.filter((p) => p.closeable)"
             item-title="label"
             item-value="id"
             selectable
@@ -212,12 +206,11 @@ watch(darkMode, () => {
         </v-menu>
       </div>
       <div class="panel-set">
-        <FloatingPanel id="charts">
-          <ChartsPanel/>
-        </FloatingPanel>
-        <FloatingPanel id="analytics" bottom>
-          <AnalyticsPanel/>
-        </FloatingPanel>
+        <FloatingPanel
+          v-for="panel, index in panelArrangement.filter((p) => p.dock == 'right')"
+          :id="panel.id"
+          :bottom="index ==  panelArrangement.filter((p) => p.dock == 'right').length -1"
+        />
       </div>
     </v-navigation-drawer>
   </div>
@@ -229,6 +222,7 @@ watch(darkMode, () => {
   border-radius: 6px;
   width: 350px !important;
   max-height: calc(100% - 15px);
+  z-index: 1 !important;
 }
 .sidebar > .v-navigation-drawer__content {
   height: 100%;
diff --git a/web/src/drag.ts b/web/src/drag.ts
index ad4ce1b5..ab775582 100644
--- a/web/src/drag.ts
+++ b/web/src/drag.ts
@@ -19,8 +19,6 @@ export function startDrag(
 export function dragPanel(event: MouseEvent) {
     let offsetX = -5;
     const offsetY = 30;
-    const snapToleranceX = 200;
-    const snapToleranceY = 300;
     const minHeight = 100;
     const minWidth = 150;
 
@@ -28,42 +26,55 @@ export function dragPanel(event: MouseEvent) {
         (p) => p.id === draggingPanel.value
     );
     if (!panel) return undefined;
+    if (draggingFrom.value) {
+        const from: { x: number; y: number } = { ...draggingFrom.value };
 
-    if (panel.right) offsetX += document.body.clientWidth - 390;
-    const position = {
-        x: event.clientX - offsetX - (panel.element?.clientWidth || 0),
-        y: event.clientY - offsetY,
-    };
-    if (dragModes.value?.includes("position")) {
-        const sidebarOpen = (
-            (panel.right && openSidebars.value.includes("right")) ||
-            (!panel.right && openSidebars.value.includes("left"))
-        )
-        if (
-            sidebarOpen &&
-            panel.initialPosition &&
-            Math.abs(position.x - panel.initialPosition.x) < snapToleranceX &&
-            Math.abs(position.y - panel.initialPosition.y) < snapToleranceY
-        ) {
-            // snap to sidebar
-            panel.position = undefined;
-        } else {
-            if (!panel.initialPosition) {
-                // convert to floating
-                panel.width = 300;
-                panel.height = 200;
-                panel.initialPosition = position;
+        if (panel.dock == 'right') offsetX += document.body.clientWidth - 390;
+        const position = {
+            x: event.clientX - offsetX - (panel.element?.clientWidth || 0),
+            y: event.clientY - offsetY,
+        };
+        if (dragModes.value?.includes("position")) {
+            const allowDock = (
+                Math.abs(from.x - event.clientX) > 10 &&
+                Math.abs(from.y - event.clientY) > 10
+            )
+            if (
+                allowDock &&
+                openSidebars.value.includes("left") &&
+                event.clientX < 350
+            ) {
+                // dock left
+                panel.dock = 'left';
+                panel.position = undefined;
+                panel.width = undefined;
+                panel.height = undefined;
+                // determine order
+                const currentDocked = panelArrangement.value.filter((p) => p.dock === 'left' && !p.position)
+                panel.order = Math.ceil(event.clientY / (document.body.clientHeight / currentDocked.length))
             } else if (
-                panel.width && position.x + panel.width < document.body.clientWidth &&
-                panel.height && position.y + panel.height < document.body.clientHeight
+                allowDock &&
+                openSidebars.value.includes("right") &&
+                event.clientX > document.body.clientWidth - 350
             ) {
+                // dock right
+                panel.dock = 'right';
+                panel.position = undefined;
+                panel.width = undefined;
+                panel.height = undefined;
+                // determine order
+                const currentDocked = panelArrangement.value.filter((p) => p.dock === 'right' && !p.position)
+                panel.order = Math.ceil(event.clientY / (document.body.clientHeight / currentDocked.length))
+            } else if (!panel.position) {
+                // float
+                panel.width = 300;
+                panel.height = 200;
+                panel.position = position;
+            } else {
                 panel.position = position;
             }
         }
-    }
-    if (draggingFrom.value) {
-        const from: { x: number; y: number } = { ...draggingFrom.value };
-        if (dragModes.value?.includes("height") && draggingFrom.value) {
+        if (dragModes.value?.includes("height")) {
             if(!panel.height) {
                 panel.height = panel.element?.clientHeight
             }
@@ -75,11 +86,7 @@ export function dragPanel(event: MouseEvent) {
                 }
             }
         }
-        if (
-            dragModes.value?.includes("width") &&
-            draggingFrom.value &&
-            panel.width
-        ) {
+        if (dragModes.value?.includes("width") && panel.width) {
             const widthDelta = event.clientX - draggingFrom.value.x;
             if (panel.width + widthDelta > minWidth) {
                 panel.width = panel.width + widthDelta;
diff --git a/web/src/storeFunctions.ts b/web/src/storeFunctions.ts
index c5ccf196..79def9fe 100644
--- a/web/src/storeFunctions.ts
+++ b/web/src/storeFunctions.ts
@@ -43,26 +43,36 @@ export function clearState() {
   currentError.value = undefined;
   polls.value = {};
   panelArrangement.value = [
-    { id: "datasets", label: "Datasets", visible: true, closeable: false },
+    { id: "datasets",
+      label: "Datasets",
+      visible: true,
+      closeable: false,
+      dock: 'left',
+      order: 1
+    },
     {
       id: "layers",
       label: "Selected Layers",
       visible: true,
       closeable: false,
+      dock: 'left',
+      order: 2,
     },
     {
       id: "charts",
       label: "Charts",
       visible: true,
       closeable: true,
-      right: true,
+      dock: 'right',
+      order: 1,
     },
     {
       id: "analytics",
       label: "Analytics",
       visible: true,
       closeable: true,
-      right: true,
+      dock: 'right',
+      order: 2,
     },
   ];
   draggingPanel.value = undefined;
diff --git a/web/src/types.ts b/web/src/types.ts
index 7e006b4e..2d334978 100644
--- a/web/src/types.ts
+++ b/web/src/types.ts
@@ -313,8 +313,8 @@ export interface FloatingPanelConfig {
   visible: boolean;
   closeable: boolean;
   collapsed?: boolean;
-  right?: boolean;
-  initialPosition?: { x: number; y: number } | undefined;
+  dock: 'left' | 'right';
+  order: number;
   position?: { x: number; y: number } | undefined;
   width?: number | undefined;
   height?: number | undefined;