From b2eb6eb96e17e8a5363a53a3f036aa474dac9a67 Mon Sep 17 00:00:00 2001 From: gangagyatso4364 Date: Tue, 9 Jan 2024 12:32:54 +0530 Subject: [PATCH 1/3] fix get_opf_path function --- openpecha/core/pecha.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openpecha/core/pecha.py b/openpecha/core/pecha.py index 6a32861d..9ca45bff 100644 --- a/openpecha/core/pecha.py +++ b/openpecha/core/pecha.py @@ -443,7 +443,7 @@ def get_opf_path(pecha_id, path: str) -> Path: return if not path: - return download_pecha(pecha_id) + path = download_pecha(pecha_id) path = Path(path) if path.name.endswith(".opf"): From fd0db3c1dd87348fed49b44ec9c265077886140a Mon Sep 17 00:00:00 2001 From: gangagyatso4364 Date: Mon, 15 Jan 2024 12:33:56 +0530 Subject: [PATCH 2/3] added test case for OpenpechaGitRepo opf_path --- tests/core/test_pecha.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/core/test_pecha.py b/tests/core/test_pecha.py index d26bf716..97ed1d40 100644 --- a/tests/core/test_pecha.py +++ b/tests/core/test_pecha.py @@ -213,3 +213,12 @@ def test_pecha_github_publish(tmp_path): pecha.publish() print(pecha.pecha_path) + + +def test_opf_path_OpenPechaGitRepo(): + from openpecha.core.pecha import OpenPechaGitRepo + from openpecha import config + pecha_id = "P000108" + opf = OpenPechaGitRepo(pecha_id=pecha_id) + expected_opf_path = config.PECHAS_PATH / pecha_id/ f"{pecha_id}.opf" + assert opf.opf_path == expected_opf_path \ No newline at end of file From d2836b58cdcea02877b3dce110c730c06ce8c737 Mon Sep 17 00:00:00 2001 From: gangagyatso4364 Date: Mon, 15 Jan 2024 13:21:28 +0530 Subject: [PATCH 3/3] added test case for OpenpechaGitRepo opf_path --- tests/core/test_pecha.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/core/test_pecha.py b/tests/core/test_pecha.py index 97ed1d40..b5bc4303 100644 --- a/tests/core/test_pecha.py +++ b/tests/core/test_pecha.py @@ -218,6 +218,10 @@ def test_pecha_github_publish(tmp_path): def test_opf_path_OpenPechaGitRepo(): from openpecha.core.pecha import OpenPechaGitRepo from openpecha import config + import os + os.environ["OPENPECHA_DATA_GITHUB_ORG"] = "OpenPecha-Data" + os.environ["GITHUB_TOKEN"] = "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" + os.environ["GITHUB_USERNAME"] = "gangagyatso4364" pecha_id = "P000108" opf = OpenPechaGitRepo(pecha_id=pecha_id) expected_opf_path = config.PECHAS_PATH / pecha_id/ f"{pecha_id}.opf"