-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format of the forces in extXYZ output file. #274
Comments
Thank you for your checking and suggestion. Your proposed solution is also quite reasonable to me. It will keep float format and slightly save some disk space. |
I wonder whether we really need eight decimal places in both of these outputs; if we reduced to (say) 4 dp for positions and 4 or 5 dp for forces (given that our convergence criterion is often around 1e-4 Ha/Bohr) that would allow output to be smaller. |
We often want to use this file to generate machine-learning force fields (ML-FF), as training data. In such cases, it is safe to have more digits. |
Thank you @tsuyoshi38 for clarifying. Do you need significant figures or decimal places for the ML-FF? I'm concerned that if we use the |
Thank you @davidbowler for the comment.
I don't think we need high precision when the forces are huge. It appears only in the MD simulations using inappropriate ML-FF, and we just want to know how large the forces are in such cases.
Thank you. I had a discussion with Augustin and Lin-san, and we agreed that we want to go with "e16.8" for now. |
Thank you @tsuyoshi38 and @davidbowler for your comments. Should I issue a pull request to the develop branch? |
Closed by #309 |
In some cases, for high values of the forces, the space allocated for writing them into an extXYZ file is insufficient and leads to unusable data, as shown below, where$F_x$ cannot be written properly:

Cause
In
io_module.f90
, lines 2937-2938f16.8
numbers can be insufficient for some specific cases (ex: calculaling the forces between two atoms at short distance)Proposed solution
Use
e16.8
instead off16.8
to output the forces.Does this sound reasonable?
The text was updated successfully, but these errors were encountered: