Added IR Break Beam and autoIntake with Ada, and also synced stuff in Swerve #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
Gold872
reviewed
Jan 17, 2024
There was a problem hiding this comment.
These constants are outdated (names have been changed), please update your branch so it doesn't conflict with the latest code
There was a problem hiding this comment.
While the intake note method will do what it is supposed to do, it won't actually end the command. and there is no timeout so it could theoretically run forever in auto
Gold872
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Why is the motor ID being used for the beam break DIO port number?
Gold872
reviewed
Jan 17, 2024
There was a problem hiding this comment.
This code is outdated by a few commits, and will conflict with the latest changes. Re-syncing your repository will fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an IR Break Beam such that if the IR beam is interrupted, it will send to smartDashboard that the intake took a note. In addition, I also created a named command such that when the intake intook a note, it will stop intaking. This will only be used during autos. Ada helped me with both of these, so give her some credit.